chrome/installer/util/installer_state_unittest.cc - Issue 606473002: Remove implicit HANDLE conversions from chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/installer_state_unittest.cc

Issue 606473002: Remove implicit HANDLE conversions from chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove spurious file and fix indent (+rebase) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/installer_state_unittest.cc

diff --git a/chrome/installer/util/installer_state_unittest.cc b/chrome/installer/util/installer_state_unittest.cc

index e0cf3bdf115d1ec16416f0c29b13ca4d2c985a42..974cb86bb3769d15fc942af3ca9cd23a06dbae31 100644

--- a/chrome/installer/util/installer_state_unittest.cc

+++ b/chrome/installer/util/installer_state_unittest.cc

@@ -486,7 +486,7 @@ TEST_F(InstallerStateTest, IsFileInUse) {

SYNCHRONIZE | FILE_EXECUTE,

FILE_SHARE_DELETE | FILE_SHARE_READ,

NULL, OPEN_EXISTING, 0, 0));

- ASSERT_TRUE(temp_handle != NULL);

+ ASSERT_TRUE(temp_handle.IsValid());

// The file should now be in use.

EXPECT_TRUE(MockInstallerState::IsFileInUse(temp_file));