Remove implicit HANDLE conversions from chrome.

chrome/installer/util/user_experiment.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/user_experiment.h"
 
 #include <windows.h>
 #include <sddl.h>
 #include <wtsapi32.h>
 #include <vector>
@@ skipping 66 matching lines @@
 // Returns -1 if there was an error retrieving the directory time.
 int GetDirectoryWriteTimeInHours(const wchar_t* path) {
   // To open a directory you need to pass FILE_FLAG_BACKUP_SEMANTICS.
   DWORD share = FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE;
   base::win::ScopedHandle file(::CreateFileW(path, 0, share, NULL,
       OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, NULL));
   if (!file.IsValid())
     return -1;
 
   FILETIME time;
-  return ::GetFileTime(file, NULL, NULL, &time) ? FileTimeToHours(time) : -1;
+  return ::GetFileTime(file.Get(), NULL, NULL, &time) ?
+             FileTimeToHours(time) : -1;

[Lei Zhang, 2014/09/24 23:10:10]

nit: indent 4 spaces from "return" ?

[rvargas (doing something else), 2014/09/24 23:58:46]

yeah, I've always hated indenting under a return as opposed to under what is
returned. done.

 }
 
 // Returns the time in hours since the last write to the user data directory.
 // A return value of 14 means that the directory was last written 14 hours ago.
 // Returns -1 if there was an error retrieving the directory.
 int GetUserDataDirectoryWriteAgeInHours() {
   base::FilePath user_data_dir;
   if (!PathService::Get(chrome::DIR_USER_DATA, &user_data_dir))
     return -1;
   int dir_time = GetDirectoryWriteTimeInHours(user_data_dir.value().c_str());
@@ skipping 408 matching lines @@
       outcome = kToastExpTriesOkGroup;
       break;
     case chrome::RESULT_CODE_NORMAL_EXIT_CANCEL:
       outcome = kToastExpCancelGroup;
       break;
     case chrome::RESULT_CODE_NORMAL_EXIT_EXP2:
       outcome = kToastExpUninstallGroup;
       break;
     default:
       outcome = kToastExpTriesErrorGroup;
-  };
+  }
   // Write to the |client| key for the last time.
   SetClient(experiment_group + outcome, true);
 
   if (outcome != kToastExpUninstallGroup)
     return;
   // The user wants to uninstall. This is a best effort operation. Note that
   // we waited for chrome to exit so the uninstall would not detect chrome
   // running.
   bool system_level_toast = CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kSystemLevelToast);
 
   CommandLine cmd(InstallUtil::GetChromeUninstallCmd(
                       system_level_toast, product.distribution()->GetType()));
   base::LaunchProcess(cmd, base::LaunchOptions(), NULL);
 }
 
 }  // namespace installer