Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8838)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 606473002: Remove implicit HANDLE conversions from chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove spurious file and fix indent (+rebase) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_util_unittest.cc ('k') | chrome/installer/util/google_update_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index c06a2fcc2d19b4ef429c82d3cfb7bd5e47f029ab..0d8293f0d63037d2c6f35c5c426bf5ee3f1fad2b 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -282,13 +282,13 @@ void CloseChromeFrameHelperProcess() {
::GetWindowThreadProcessId(window, &pid);
DCHECK_NE(pid, 0U);
base::win::ScopedHandle process(::OpenProcess(SYNCHRONIZE, FALSE, pid));
- PLOG_IF(INFO, !process) << "Failed to open process: " << pid;
+ PLOG_IF(INFO, !process.IsValid()) << "Failed to open process: " << pid;
bool kill = true;
if (SendMessageTimeout(window, WM_CLOSE, 0, 0, SMTO_BLOCK, kWaitMs, NULL) &&
- process) {
+ process.IsValid()) {
VLOG(1) << "Waiting for " << installer::kChromeFrameHelperExe;
- DWORD wait = ::WaitForSingleObject(process, kWaitMs);
+ DWORD wait = ::WaitForSingleObject(process.Get(), kWaitMs);
if (wait != WAIT_OBJECT_0) {
LOG(WARNING) << "Wait for " << installer::kChromeFrameHelperExe
<< " to exit failed or timed out.";
« no previous file with comments | « chrome/installer/setup/setup_util_unittest.cc ('k') | chrome/installer/util/google_update_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698