chrome/installer/gcapi/gcapi.cc - Issue 606473002: Remove implicit HANDLE conversions from chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/gcapi/gcapi.cc

Issue 606473002: Remove implicit HANDLE conversions from chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove spurious file and fix indent (+rebase) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/gcapi/gcapi.cc

diff --git a/chrome/installer/gcapi/gcapi.cc b/chrome/installer/gcapi/gcapi.cc

index ce0d22a0dbc894f590a233f47346c35739f965e4..ce03d857fd6aece4c2137ae06e82ed5754816150 100644

--- a/chrome/installer/gcapi/gcapi.cc

+++ b/chrome/installer/gcapi/gcapi.cc

@@ -478,7 +478,8 @@ BOOL __stdcall LaunchGoogleChrome() {

if (process_handle.IsValid()) {

HANDLE process_token = NULL;

HANDLE user_token = NULL;

- if (::OpenProcessToken(process_handle, TOKEN_DUPLICATE | TOKEN_QUERY,

+ if (::OpenProcessToken(process_handle.Get(),

+ TOKEN_DUPLICATE | TOKEN_QUERY,

&process_token) &&

::DuplicateTokenEx(process_token,

TOKEN_IMPERSONATE | TOKEN_QUERY |

« no previous file with comments | « chrome/common/service_process_util_win.cc ('k') | chrome/installer/setup/setup_util.cc » ('j') | no next file with comments »