Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 605163004: Land Recent QUIC Changes. (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, alyssar, Ian Swett, rjshade, Jana
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0925
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Change the pre-handshake idle timeout to 5s from 120s, and the default idle timeout is 30s. This ensures clients don't wait more than 5s if the connection has UDP blackholed. Merge internal change: 76444120 https://codereview.chromium.org/610073002/ Add a convenience method to check for client supplied options in QuicSentPacketManager. Merge internal change: 76423808 https://codereview.chromium.org/607803004/ Add a QUIC tag to connection options to allow negotiating 1 connection emulation in congestion control algorithms. Merge internal change: 76351810 https://codereview.chromium.org/606503004/ Allow the number of connections QUIC's send algorithms simulate to change, either initially or throughout the connection. Merge internal change: 76297032 https://codereview.chromium.org/610053002/ Remove support for QUIC_VERSION_16. Merge internal change: 76286812 https://codereview.chromium.org/601663004/ QUIC server max streams is now at least 10 streams larger than configured limit. Protected by existing FLAGS_quic_allow_more_open_streams. Merge internal change: 76269911 https://codereview.chromium.org/607763007/ No functional change. Rename QuicConfig methods from lowercase with underscores to CamelCase, since they're not direct field accessors. Merge internal change: 76185470 https://codereview.chromium.org/608453007/ Add a test to ensure QUIC's TcpCubicSender always allows packets to be sent when there is less than a packet in flight. Merge internal change: 76165601 https://codereview.chromium.org/608003002/ Merge QuicSentPacketManager::DebugDelegate's OnSentPacket, OnRetransmittedPacket, and OnSerializedPacket into one OnSentPacket. Merge internal change: 76088200 https://codereview.chromium.org/607983002/ Remove OnPacketRetransmitted from QuicConnectionDebugVisitor. Merge internal change: 76084748 https://codereview.chromium.org/605263003/ R=rch@chromium.org Committed: https://crrev.com/b5512bbf96db9a3df17f324f79f883a9dd15bf7a Cr-Commit-Position: refs/heads/master@{#297225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -456 lines) Patch
M net/quic/congestion_control/cubic.h View 2 chunks +10 lines, -0 lines 0 comments Download
M net/quic/congestion_control/cubic.cc View 3 chunks +24 lines, -16 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 7 chunks +77 lines, -2 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_config.h View 5 chunks +31 lines, -15 lines 0 comments Download
M net/quic/quic_config.cc View 6 chunks +20 lines, -27 lines 0 comments Download
M net/quic/quic_config_test.cc View 8 chunks +20 lines, -20 lines 0 comments Download
M net/quic/quic_connection.h View 3 chunks +8 lines, -6 lines 0 comments Download
M net/quic/quic_connection.cc View 8 chunks +37 lines, -32 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 4 chunks +7 lines, -23 lines 0 comments Download
M net/quic/quic_connection_test.cc View 4 chunks +105 lines, -32 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/quic_data_stream_test.cc View 5 chunks +0 lines, -17 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M net/quic/quic_framer.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M net/quic/quic_framer_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_protocol.h View 4 chunks +13 lines, -8 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_protocol_test.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 3 chunks +7 lines, -14 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 5 chunks +27 lines, -34 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M net/quic/quic_session.cc View 6 chunks +19 lines, -19 lines 0 comments Download
M net/quic/quic_session_test.cc View 5 chunks +3 lines, -15 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_client_session_peer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 6 chunks +5 lines, -27 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 4 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
6 years, 2 months ago (2014-09-27 01:18:24 UTC) #1
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-09-27 04:13:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605163004/1
6 years, 2 months ago (2014-09-29 18:20:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as de37f0afcf8e30ef1fc35589645b95802a5ae9b4
6 years, 2 months ago (2014-09-29 19:17:23 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 19:18:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5512bbf96db9a3df17f324f79f883a9dd15bf7a
Cr-Commit-Position: refs/heads/master@{#297225}

Powered by Google App Engine
This is Rietveld 408576698