Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: net/quic/reliable_quic_stream_test.cc

Issue 605163004: Land Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0925
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | net/quic/test_tools/mock_crypto_client_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream_test.cc
diff --git a/net/quic/reliable_quic_stream_test.cc b/net/quic/reliable_quic_stream_test.cc
index 535e4408000f3a9deacb76cea1b5fc9ebce5271e..9b0eccdc2936505996f94cdce8282d8e17420b99 100644
--- a/net/quic/reliable_quic_stream_test.cc
+++ b/net/quic/reliable_quic_stream_test.cc
@@ -426,29 +426,6 @@ TEST_F(ReliableQuicStreamTest, StreamFlowControlMultipleWindowUpdates) {
QuicFlowControllerPeer::SendWindowOffset(stream_->flow_controller()));
}
-TEST_F(ReliableQuicStreamTest, StreamFlowControlShouldNotBlockInLessThanQ017) {
- // TODO(rjshade): Remove this test when we no longer have any versions <
- // QUIC_VERSION_17.
-
- // Make sure we are using a version which does not support flow control.
- QuicVersion kTestQuicVersions[] = {QUIC_VERSION_16};
- QuicVersionVector versions;
- for (size_t i = 0; i < arraysize(kTestQuicVersions); ++i) {
- versions.push_back(kTestQuicVersions[i]);
- }
- set_supported_versions(versions);
-
- // Peer is not talking QUIC_VERSION_17 so assumes that it can send a zero
- // length flow control receive window with no consequences.
- set_initial_flow_control_window_bytes(0);
-
- Initialize(kShouldProcessData);
-
- // The stream should _not_ be flow control blocked, because we are not talking
- // a version which has flow control enabled.
- EXPECT_FALSE(stream_->flow_controller()->IsBlocked());
-}
-
void SaveProxyAckNotifierDelegate(
scoped_refptr<QuicAckNotifier::DelegateInterface>* delegate_out,
QuicAckNotifier::DelegateInterface* delegate) {
« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | net/quic/test_tools/mock_crypto_client_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698