Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: net/quic/quic_session_test.cc

Issue 605163004: Land Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0925
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session_test.cc
diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc
index 32751346896754dd36a7a1fd2ee4c79d1401bff0..bff6a65ac0e19f217c17e666af8a85be474854bd 100644
--- a/net/quic/quic_session_test.cc
+++ b/net/quic/quic_session_test.cc
@@ -578,8 +578,8 @@ TEST_P(QuicSessionTest, DoNotSendGoAwayTwice) {
}
TEST_P(QuicSessionTest, IncreasedTimeoutAfterCryptoHandshake) {
- // Add 1 to the connection timeout on the server side.
- EXPECT_EQ(kDefaultInitialTimeoutSecs + 1,
+ EXPECT_EQ((FLAGS_quic_unified_timeouts ?
+ kInitialIdleTimeoutSecs : kDefaultIdleTimeoutSecs) + 1,
QuicConnectionPeer::GetNetworkTimeout(connection_).ToSeconds());
CryptoHandshakeMessage msg;
session_.GetCryptoStream()->OnHandshakeMessage(msg);
@@ -632,9 +632,6 @@ TEST_P(QuicSessionTest, MultipleRstStreamsCauseSingleConnectionClose) {
TEST_P(QuicSessionTest, HandshakeUnblocksFlowControlBlockedStream) {
// Test that if a stream is flow control blocked, then on receipt of the SHLO
// containing a suitable send window offset, the stream becomes unblocked.
- if (version() <= QUIC_VERSION_16) {
- return;
- }
// Ensure that Writev consumes all the data it is given (simulate no socket
// blocking).
@@ -660,7 +657,7 @@ TEST_P(QuicSessionTest, InvalidFlowControlWindowInHandshake) {
// TODO(rjshade): Remove this test when removing QUIC_VERSION_19.
// Test that receipt of an invalid (< default) flow control window from
// the peer results in the connection being torn down.
- if (version() <= QUIC_VERSION_16 || version() > QUIC_VERSION_19) {
+ if (version() > QUIC_VERSION_19) {
return;
}
@@ -857,10 +854,6 @@ TEST_P(QuicSessionTest, ConnectionFlowControlAccountingRstAfterRst) {
TEST_P(QuicSessionTest, FlowControlWithInvalidFinalOffset) {
// Test that if we receive a stream RST with a highest byte offset that
// violates flow control, that we close the connection.
- if (version() <= QUIC_VERSION_16) {
- return;
- }
-
const uint64 kLargeOffset = kInitialSessionFlowControlWindowForTest + 1;
EXPECT_CALL(*connection_,
SendConnectionClose(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA))
@@ -898,11 +891,6 @@ TEST_P(QuicSessionTest, VersionNegotiationDisablesFlowControl) {
session_.OnSuccessfulVersionNegotiation(QUIC_VERSION_18);
EXPECT_FALSE(session_.flow_controller()->IsEnabled());
EXPECT_TRUE(stream->flow_controller()->IsEnabled());
-
- // Version 16 means all flow control is disabled.
- session_.OnSuccessfulVersionNegotiation(QUIC_VERSION_16);
- EXPECT_FALSE(session_.flow_controller()->IsEnabled());
- EXPECT_FALSE(stream->flow_controller()->IsEnabled());
}
TEST_P(QuicSessionTest, WindowUpdateUnblocksHeadersStream) {
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698