Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Unified Diff: net/quic/quic_framer.cc

Issue 605163004: Land Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0925
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_flow_controller_test.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_framer.cc
diff --git a/net/quic/quic_framer.cc b/net/quic/quic_framer.cc
index 84c6b308417e6a0b036c4c8cce36a729ec0d3d7e..1f1340c0be7704237cbcb19e10de7725f79d4425 100644
--- a/net/quic/quic_framer.cc
+++ b/net/quic/quic_framer.cc
@@ -375,11 +375,6 @@ SerializedPacket QuicFramer::BuildDataPacket(
}
break;
case PING_FRAME:
- if (quic_version_ == QUIC_VERSION_16) {
- LOG(DFATAL) << "Attempt to add a PingFrame in "
- << QuicVersionToString(quic_version_);
- return kNoPacket;
- }
// Ping has no payload.
break;
case RST_STREAM_FRAME:
@@ -1236,11 +1231,6 @@ bool QuicFramer::ProcessFrameData(const QuicPacketHeader& header) {
continue;
}
case PING_FRAME: {
- if (quic_version_ == QUIC_VERSION_16) {
- LOG(DFATAL) << "Trying to read a Ping in "
- << QuicVersionToString(quic_version_);
- return RaiseError(QUIC_INTERNAL_ERROR);
- }
// Ping has no payload.
QuicPingFrame ping_frame;
if (!visitor_->OnPingFrame(ping_frame)) {
« no previous file with comments | « net/quic/quic_flow_controller_test.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698