Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 600083003: Fix memory leak in Sync FakeServerEntity (Closed)

Created:
6 years, 2 months ago by pval...(no longer on Chromium)
Modified:
6 years, 2 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Fix memory leak in Sync FakeServerEntity SyncEntity protos in fake_server.cc are now populated by passing a pointer to FakeServerEntity.SerializeAsProto. Previously, SerializeAsProto returned a newly-created proto that was never deleted. BUG=NONE Committed: https://crrev.com/f89c3a34a93ae0bccf69046febe03c61b14f932f Cr-Commit-Position: refs/heads/master@{#296733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -43 lines) Patch
M sync/test/fake_server/bookmark_entity.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/fake_server/bookmark_entity.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M sync/test/fake_server/fake_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/fake_server/fake_server_entity.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/fake_server/permanent_entity.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/fake_server/permanent_entity.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M sync/test/fake_server/tombstone_entity.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/fake_server/tombstone_entity.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M sync/test/fake_server/unique_client_entity.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/fake_server/unique_client_entity.cc View 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pval...(no longer on Chromium)
6 years, 2 months ago (2014-09-24 23:14:51 UTC) #2
Nicolas Zea
LGTM. I'm kind of surprised this didn't trigger memory leaks on the memory bots
6 years, 2 months ago (2014-09-24 23:16:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600083003/1
6 years, 2 months ago (2014-09-24 23:30:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/18791)
6 years, 2 months ago (2014-09-24 23:45:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600083003/1
6 years, 2 months ago (2014-09-25 17:16:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as a762732abde64eb6dfd1985692c4523451b082a0
6 years, 2 months ago (2014-09-25 17:34:12 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 17:34:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f89c3a34a93ae0bccf69046febe03c61b14f932f
Cr-Commit-Position: refs/heads/master@{#296733}

Powered by Google App Engine
This is Rietveld 408576698