Fix memory leak in Sync FakeServerEntity

sync/test/fake_server/bookmark_entity.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/test/fake_server/bookmark_entity.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/guid.h"
@@ skipping 90 matching lines @@
       specifics_(specifics),
       is_folder_(is_folder),
       parent_id_(parent_id),
       creation_time_(creation_time),
       last_modified_time_(last_modified_time) { }
 
 string BookmarkEntity::GetParentId() const {
   return parent_id_;
 }
 
-sync_pb::SyncEntity* BookmarkEntity::SerializeAsProto() {
-  sync_pb::SyncEntity* sync_entity = new sync_pb::SyncEntity();
-  FakeServerEntity::SerializeBaseProtoFields(sync_entity);
+void BookmarkEntity::SerializeAsProto(sync_pb::SyncEntity* proto) {
+  FakeServerEntity::SerializeBaseProtoFields(proto);
 
-  sync_pb::EntitySpecifics* specifics = sync_entity->mutable_specifics();
+  sync_pb::EntitySpecifics* specifics = proto->mutable_specifics();
   specifics->CopyFrom(specifics_);
 
-  sync_entity->set_originator_cache_guid(originator_cache_guid_);
-  sync_entity->set_originator_client_item_id(originator_client_item_id_);
+  proto->set_originator_cache_guid(originator_cache_guid_);
+  proto->set_originator_client_item_id(originator_client_item_id_);
 
-  sync_entity->set_parent_id_string(parent_id_);
-  sync_entity->set_ctime(creation_time_);
-  sync_entity->set_mtime(last_modified_time_);
+  proto->set_parent_id_string(parent_id_);
+  proto->set_ctime(creation_time_);
+  proto->set_mtime(last_modified_time_);
 
-  sync_pb::UniquePosition* unique_position =
-      sync_entity->mutable_unique_position();
+  sync_pb::UniquePosition* unique_position = proto->mutable_unique_position();
   unique_position->CopyFrom(unique_position_);
-
-  return sync_entity;
 }
 
 bool BookmarkEntity::IsDeleted() const {
   return false;
 }
 
 bool BookmarkEntity::IsFolder() const {
   return is_folder_;
 }
 
 }  // namespace fake_server