Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Side by Side Diff: sync/test/fake_server/unique_client_entity.h

Issue 600083003: Fix memory leak in Sync FakeServerEntity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_TEST_FAKE_SERVER_UNIQUE_CLIENT_ENTITY_H_ 5 #ifndef SYNC_TEST_FAKE_SERVER_UNIQUE_CLIENT_ENTITY_H_
6 #define SYNC_TEST_FAKE_SERVER_UNIQUE_CLIENT_ENTITY_H_ 6 #define SYNC_TEST_FAKE_SERVER_UNIQUE_CLIENT_ENTITY_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 10 matching lines...) Expand all
21 21
22 // Factory function for creating a UniqueClientEntity. 22 // Factory function for creating a UniqueClientEntity.
23 static FakeServerEntity* Create(const sync_pb::SyncEntity& client_entity); 23 static FakeServerEntity* Create(const sync_pb::SyncEntity& client_entity);
24 24
25 // Derives an ID from a unique client tagged entity. 25 // Derives an ID from a unique client tagged entity.
26 static std::string EffectiveIdForClientTaggedEntity( 26 static std::string EffectiveIdForClientTaggedEntity(
27 const sync_pb::SyncEntity& entity); 27 const sync_pb::SyncEntity& entity);
28 28
29 // FakeServerEntity implementation. 29 // FakeServerEntity implementation.
30 virtual std::string GetParentId() const OVERRIDE; 30 virtual std::string GetParentId() const OVERRIDE;
31 virtual sync_pb::SyncEntity* SerializeAsProto() OVERRIDE; 31 virtual void SerializeAsProto(sync_pb::SyncEntity* proto) OVERRIDE;
32 virtual bool IsDeleted() const OVERRIDE; 32 virtual bool IsDeleted() const OVERRIDE;
33 virtual bool IsFolder() const OVERRIDE; 33 virtual bool IsFolder() const OVERRIDE;
34 34
35 private: 35 private:
36 UniqueClientEntity(const std::string& id, 36 UniqueClientEntity(const std::string& id,
37 const syncer::ModelType& model_type, 37 const syncer::ModelType& model_type,
38 int64 version, 38 int64 version,
39 const std::string& name, 39 const std::string& name,
40 const std::string& client_defined_unique_tag, 40 const std::string& client_defined_unique_tag,
41 const sync_pb::EntitySpecifics& specifics, 41 const sync_pb::EntitySpecifics& specifics,
42 int64 creation_time, 42 int64 creation_time,
43 int64 last_modified_time); 43 int64 last_modified_time);
44 44
45 // These member values have equivalent fields in SyncEntity. 45 // These member values have equivalent fields in SyncEntity.
46 std::string client_defined_unique_tag_; 46 std::string client_defined_unique_tag_;
47 sync_pb::EntitySpecifics specifics_; 47 sync_pb::EntitySpecifics specifics_;
48 int64 creation_time_; 48 int64 creation_time_;
49 int64 last_modified_time_; 49 int64 last_modified_time_;
50 }; 50 };
51 51
52 } // namespace fake_server 52 } // namespace fake_server
53 53
54 #endif // SYNC_TEST_FAKE_SERVER_UNIQUE_CLIENT_ENTITY_H_ 54 #endif // SYNC_TEST_FAKE_SERVER_UNIQUE_CLIENT_ENTITY_H_
OLDNEW
« no previous file with comments | « sync/test/fake_server/tombstone_entity.cc ('k') | sync/test/fake_server/unique_client_entity.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698