Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: sync/test/fake_server/fake_server.cc

Issue 600083003: Fix memory leak in Sync FakeServerEntity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/test/fake_server/bookmark_entity.cc ('k') | sync/test/fake_server/fake_server_entity.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/test/fake_server/fake_server.cc
diff --git a/sync/test/fake_server/fake_server.cc b/sync/test/fake_server/fake_server.cc
index 854eabec6c5b8207afac3d95b00df2c23af78219..ea4abfd7cf55812003e8e7d8ccc47bee2bc5024e 100644
--- a/sync/test/fake_server/fake_server.cc
+++ b/sync/test/fake_server/fake_server.cc
@@ -288,7 +288,7 @@ bool FakeServer::HandleGetUpdatesRequest(
FakeServerEntity* entity = it->second;
if (sieve->ClientWantsItem(entity)) {
sync_pb::SyncEntity* response_entity = response->add_entries();
- response_entity->CopyFrom(*(entity->SerializeAsProto()));
+ entity->SerializeAsProto(response_entity);
max_response_version = std::max(max_response_version,
response_entity->version());
« no previous file with comments | « sync/test/fake_server/bookmark_entity.cc ('k') | sync/test/fake_server/fake_server_entity.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698