Fix memory leak in Sync FakeServerEntity

sync/test/fake_server/permanent_entity.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/test/fake_server/permanent_entity.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 80 matching lines @@
                                  const sync_pb::EntitySpecifics& specifics)
     : FakeServerEntity(id, model_type, 0, name),
       server_defined_unique_tag_(server_defined_unique_tag),
       parent_id_(parent_id),
       specifics_(specifics) { }
 
 string PermanentEntity::GetParentId() const {
   return parent_id_;
 }
 
-sync_pb::SyncEntity* PermanentEntity::SerializeAsProto() {
-  sync_pb::SyncEntity* sync_entity = new sync_pb::SyncEntity();
-  FakeServerEntity::SerializeBaseProtoFields(sync_entity);
+void PermanentEntity::SerializeAsProto(sync_pb::SyncEntity* proto) {
+  FakeServerEntity::SerializeBaseProtoFields(proto);
 
-  sync_pb::EntitySpecifics* specifics = sync_entity->mutable_specifics();
+  sync_pb::EntitySpecifics* specifics = proto->mutable_specifics();
   specifics->CopyFrom(specifics_);
 
-  sync_entity->set_parent_id_string(parent_id_);
-  sync_entity->set_server_defined_unique_tag(server_defined_unique_tag_);
-
-  return sync_entity;
+  proto->set_parent_id_string(parent_id_);
+  proto->set_server_defined_unique_tag(server_defined_unique_tag_);
 }
 
 bool PermanentEntity::IsDeleted() const {
   return false;
 }
 
 bool PermanentEntity::IsFolder() const {
   return true;
 }
 
 }  // namespace fake_server