Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1587)

Issue 599163003: Add whitelist for extensions to put <all_urls> in externally_connectable (Closed)

Created:
6 years, 3 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 2 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add whitelist for extensions to put <all_urls> in externally_connectable Normally extensions must specify a concrete list of url patterns. But with this patch, extensions on the whitelist can do: "permissions": ["externally_connectable.all_urls"], "externally_connectable": { "matches": ["<all_urls>"] } and they will be able to be connected to from any url. Also add an entry to the whitelist for the CryptoToken extension. BUG=417062, 417494 Committed: https://crrev.com/860c6547ac322954027fc226e75881f15585f14b Cr-Commit-Position: refs/heads/master@{#296799}

Patch Set 1 #

Patch Set 2 : fixed permission warnings unittest #

Messages

Total messages: 12 (4 generated)
asargent_no_longer_on_chrome
6 years, 3 months ago (2014-09-24 23:17:43 UTC) #2
miket_OOO
lgtm
6 years, 3 months ago (2014-09-25 00:29:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599163003/1
6 years, 2 months ago (2014-09-25 16:02:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/19802)
6 years, 2 months ago (2014-09-25 17:11:44 UTC) #7
asargent_no_longer_on_chrome
Updated CL with a fix for the unit test and hitting CQ button again.
6 years, 2 months ago (2014-09-25 19:52:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599163003/20001
6 years, 2 months ago (2014-09-25 19:54:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 82ec43558a91d6f0a6c09f472be1e49057593ac3
6 years, 2 months ago (2014-09-25 21:48:15 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 21:48:51 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/860c6547ac322954027fc226e75881f15585f14b
Cr-Commit-Position: refs/heads/master@{#296799}

Powered by Google App Engine
This is Rietveld 408576698