Index: extensions/common/manifest_handlers/externally_connectable_unittest.cc |
diff --git a/extensions/common/manifest_handlers/externally_connectable_unittest.cc b/extensions/common/manifest_handlers/externally_connectable_unittest.cc |
index 7064869c3ab36425d4ee96d43a9a7fdf0a98a6a2..9dedff3a4f09a9514dbb37a09019a39bede8a883 100644 |
--- a/extensions/common/manifest_handlers/externally_connectable_unittest.cc |
+++ b/extensions/common/manifest_handlers/externally_connectable_unittest.cc |
@@ -253,12 +253,31 @@ TEST_F(ExternallyConnectableTest, WarningNoAllURLs) { |
ErrorUtils::FormatErrorMessage(errors::kErrorWildcardHostsNotAllowed, |
"<all_urls>")); |
ExternallyConnectableInfo* info = GetExternallyConnectableInfo(extension); |
+ EXPECT_FALSE(info->matches.MatchesAllURLs()); |
EXPECT_FALSE(info->matches.ContainsPattern( |
URLPattern(URLPattern::SCHEME_ALL, "<all_urls>"))); |
EXPECT_TRUE(info->matches.MatchesURL(GURL("https://example.com"))); |
EXPECT_TRUE(info->matches.MatchesURL(GURL("http://build.chromium.org"))); |
} |
+TEST_F(ExternallyConnectableTest, AllURLsNotWhitelisted) { |
+ scoped_refptr<Extension> extension = LoadAndExpectSuccess( |
+ "externally_connectable_all_urls_not_whitelisted.json"); |
+ ExternallyConnectableInfo* info = GetExternallyConnectableInfo(extension); |
+ EXPECT_FALSE(info->matches.MatchesAllURLs()); |
+} |
+ |
+TEST_F(ExternallyConnectableTest, AllURLsWhitelisted) { |
+ scoped_refptr<Extension> extension = |
+ LoadAndExpectSuccess("externally_connectable_all_urls_whitelisted.json"); |
+ ExternallyConnectableInfo* info = GetExternallyConnectableInfo(extension); |
+ EXPECT_TRUE(info->matches.MatchesAllURLs()); |
+ URLPattern pattern(URLPattern::SCHEME_ALL, "<all_urls>"); |
+ EXPECT_TRUE(info->matches.ContainsPattern(pattern)); |
+ EXPECT_TRUE(info->matches.MatchesURL(GURL("https://example.com"))); |
+ EXPECT_TRUE(info->matches.MatchesURL(GURL("http://build.chromium.org"))); |
+} |
+ |
TEST_F(ExternallyConnectableTest, WarningWildcardHost) { |
scoped_refptr<Extension> extension = LoadAndExpectWarning( |
"externally_connectable_error_wildcard_host.json", |