Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 599163003: Add whitelist for extensions to put <all_urls> in externally_connectable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed permission warnings unittest Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | extensions/common/api/_permission_features.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/json/json_file_value_serializer.h" 6 #include "base/json/json_file_value_serializer.h"
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 751 matching lines...) Expand 10 before | Expand all | Expand 10 after
762 762
763 // Platform apps. 763 // Platform apps.
764 skip.insert(APIPermission::kBrowser); 764 skip.insert(APIPermission::kBrowser);
765 skip.insert(APIPermission::kFileSystem); 765 skip.insert(APIPermission::kFileSystem);
766 skip.insert(APIPermission::kFileSystemProvider); 766 skip.insert(APIPermission::kFileSystemProvider);
767 skip.insert(APIPermission::kFileSystemRetainEntries); 767 skip.insert(APIPermission::kFileSystemRetainEntries);
768 skip.insert(APIPermission::kFileSystemWrite); 768 skip.insert(APIPermission::kFileSystemWrite);
769 skip.insert(APIPermission::kSocket); 769 skip.insert(APIPermission::kSocket);
770 skip.insert(APIPermission::kUsbDevice); 770 skip.insert(APIPermission::kUsbDevice);
771 771
772 // We already have a generic message for declaring externally_connectable.
773 skip.insert(APIPermission::kExternallyConnectableAllUrls);
774
772 PermissionsInfo* info = PermissionsInfo::GetInstance(); 775 PermissionsInfo* info = PermissionsInfo::GetInstance();
773 APIPermissionSet permissions = info->GetAll(); 776 APIPermissionSet permissions = info->GetAll();
774 for (APIPermissionSet::const_iterator i = permissions.begin(); 777 for (APIPermissionSet::const_iterator i = permissions.begin();
775 i != permissions.end(); ++i) { 778 i != permissions.end(); ++i) {
776 const APIPermissionInfo* permission_info = i->info(); 779 const APIPermissionInfo* permission_info = i->info();
777 EXPECT_TRUE(permission_info != NULL); 780 EXPECT_TRUE(permission_info != NULL);
778 781
779 if (skip.count(i->id())) { 782 if (skip.count(i->id())) {
780 EXPECT_EQ(PermissionMessage::kNone, permission_info->message_id()) 783 EXPECT_EQ(PermissionMessage::kNone, permission_info->message_id())
781 << "unexpected message_id for " << permission_info->name(); 784 << "unexpected message_id for " << permission_info->name();
(...skipping 1063 matching lines...) Expand 10 before | Expand all | Expand 10 after
1845 scoped_refptr<const PermissionSet> permissions_dwr( 1848 scoped_refptr<const PermissionSet> permissions_dwr(
1846 extension_dwr->permissions_data()->active_permissions()); 1849 extension_dwr->permissions_data()->active_permissions());
1847 1850
1848 EXPECT_FALSE(PermissionMessageProvider::Get()-> 1851 EXPECT_FALSE(PermissionMessageProvider::Get()->
1849 IsPrivilegeIncrease(permissions.get(), 1852 IsPrivilegeIncrease(permissions.get(),
1850 permissions_dwr.get(), 1853 permissions_dwr.get(),
1851 extension->GetType())); 1854 extension->GetType()));
1852 } 1855 }
1853 1856
1854 } // namespace extensions 1857 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | extensions/common/api/_permission_features.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698