extensions/common/manifest_handlers/externally_connectable.h - Issue 599163003: Add whitelist for extensions to put <all_urls> in externally_connectable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/externally_connectable.h

Issue 599163003: Add whitelist for extensions to put <all_urls> in externally_connectable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed permission warnings unittest Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/api/_permission_features.json ('k') | extensions/common/manifest_handlers/externally_connectable.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_handlers/externally_connectable.h

diff --git a/extensions/common/manifest_handlers/externally_connectable.h b/extensions/common/manifest_handlers/externally_connectable.h

index 960904e01a13665726fa47af0711c4b7de302b4e..f72ff45646577720233153ca55c5ce90bd3dec7e 100644

--- a/extensions/common/manifest_handlers/externally_connectable.h

+++ b/extensions/common/manifest_handlers/externally_connectable.h

@@ -57,6 +57,7 @@ struct ExternallyConnectableInfo : public Extension::ManifestData {

// the manifest. Sets |error| and returns an empty scoped_ptr on failure.

static scoped_ptr<ExternallyConnectableInfo> FromValue(

const base::Value& value,

+ bool allow_all_urls,

std::vector<InstallWarning>* install_warnings,

base::string16* error);

« no previous file with comments | « extensions/common/api/_permission_features.json ('k') | extensions/common/manifest_handlers/externally_connectable.cc » ('j') | no next file with comments »