extensions/common/permissions/extensions_api_permissions.cc - Issue 599163003: Add whitelist for extensions to put <all_urls> in externally_connectable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/extensions_api_permissions.cc

Issue 599163003: Add whitelist for extensions to put <all_urls> in externally_connectable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed permission warnings unittest Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/api_permission.h ('k') | extensions/test/data/manifest_tests/externally_connectable_all_urls_not_whitelisted.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/extensions_api_permissions.cc

diff --git a/extensions/common/permissions/extensions_api_permissions.cc b/extensions/common/permissions/extensions_api_permissions.cc

index efad143d916ec80b950eddec3faf2592f11cd405..498990ce3949ee878ea84ef615b213068b7a1bae 100644

--- a/extensions/common/permissions/extensions_api_permissions.cc

+++ b/extensions/common/permissions/extensions_api_permissions.cc

@@ -36,6 +36,8 @@ std::vector<APIPermissionInfo*> ExtensionsAPIPermissions::GetAllPermissions()

APIPermissionInfo::kFlagNone, IDS_EXTENSION_PROMPT_WARNING_AUDIO_CAPTURE,

PermissionMessage::kAudioCapture},

{APIPermission::kDns, "dns"},

+ {APIPermission::kExternallyConnectableAllUrls,

+ "externally_connectable.all_urls"},

{APIPermission::kFullscreen, "app.window.fullscreen"},

{APIPermission::kHid, "hid", APIPermissionInfo::kFlagNone,

IDS_EXTENSION_PROMPT_WARNING_HID, PermissionMessage::kHid},