Setting max TTL for upstream GCM messages to 1 day to match server side

Setting max TTL for upstream GCM messages to 1 day to match server side

Updating relevant tests.

BUG=413801
R=jianli@chromium.org,zea@chromium.org,scheib@chromium.org

Committed: https://crrev.com/0dfb6cdfa63a13d74758b1e97c33b7f4941f1e57
Cr-Commit-Position: refs/heads/master@{#296083}

[fgorski, 2014-09-22 18:41:04]

fgorski@chromium.org changed reviewers:
+ scheib@chromium.org, zea@chromium.org
- kalman@chromium.org

[fgorski, 2014-09-22 18:44:51]

Please take a look.

This is a safe change because we don't have that many upstream consumers (max <
200 messages per day, typically 0), and service already limits the TTL to a
single day.

Relevant histogram is busted, so I cannot give exact numbers (bug filed)

[jianli, 2014-09-22 18:48:58]

lgtm

https://codereview.chromium.org/589663004/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/gcm/gcm_apitest.cc (right):

https://codereview.chromium.org/589663004/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcm/gcm_apitest.cc:174: EXPECT_EQ(24 * 60 * 60,
message.time_to_live);
nit: can you refer to OutgoingMessage::kMaximumTTL constant?

[Nicolas Zea, 2014-09-22 19:01:39]

https://developer.android.com/google/gcm/adv.html#ttl Seems to claim the TTL is
4 weeks. Is that not right?

[fgorski, 2014-09-22 20:04:09]

On 2014/09/22 19:01:39, Nicolas Zea wrote:
> https://developer.android.com/google/gcm/adv.html#ttl Seems to claim the TTL
is
> 4 weeks. Is that not right?

It's right, but it applies to downstream.

For downstream please refer to:
http://www.youtube.com/watch?v=owhf42SZadk  at 4:22

[Nicolas Zea, 2014-09-22 20:07:30]

ah, got it. LGTM then

[fgorski, 2014-09-22 21:12:50]

Addressed feedback (Jian, PTAL) and rerunning try bots.

https://codereview.chromium.org/589663004/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/gcm/gcm_apitest.cc (right):

https://codereview.chromium.org/589663004/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/gcm/gcm_apitest.cc:174:
EXPECT_EQ(gcm::GCMClient::OutgoingMessage::kMaximumTTL, message.time_to_live);
Done.

I was initially getting a linker error, but moving the initialization of the
const into the gcm_client.cc file fixed the issue -- it was not necessary to
update GYP files, based the success of my latest local build. Just in case
running try bots again.

[scheib, 2014-09-22 22:56:26]

lgtm

[fgorski, 2014-09-22 22:59:52]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-09-22 23:00:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589663004/20001

[commit-bot: I haz the power, 2014-09-22 23:06:03]

Committed patchset #2 (id:20001) as b6d7a99d8c352c43a2249a96211ee6076ef55d85

[commit-bot: I haz the power, 2014-09-22 23:06:37]

Patchset 2 (id:??) landed as
https://crrev.com/0dfb6cdfa63a13d74758b1e97c33b7f4941f1e57
Cr-Commit-Position: refs/heads/master@{#296083}