google_apis/gcm/base/mcs_util.cc - Issue 589663004: Setting max TTL for upstream GCM messages to 1 day to match server side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/base/mcs_util.cc

Issue 589663004: Setting max TTL for upstream GCM messages to 1 day to match server side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing CL feedback Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/base/mcs_util.cc

diff --git a/google_apis/gcm/base/mcs_util.cc b/google_apis/gcm/base/mcs_util.cc

index b578e573922e9ea93c86711c30a5e6a6ca564ada..ceccc957cbe1659c86eb34ba4ca94b608010b004 100644

--- a/google_apis/gcm/base/mcs_util.cc

+++ b/google_apis/gcm/base/mcs_util.cc

@@ -46,7 +46,7 @@ const char kLoginSettingDefaultName[] = "new_vc";

const char kLoginSettingDefaultValue[] = "1";

// Maximum amount of time to save an unsent outgoing message for.

-const int kMaxTTLSeconds = 4 * 7 * 24 * 60 * 60; // 4 weeks.

+const int kMaxTTLSeconds = 24 * 60 * 60; // 1 day.

} // namespace

« chrome/browser/extensions/api/gcm/gcm_apitest.cc ('K') | « components/gcm_driver/gcm_client.cc ('k') | no next file » | no next file with comments »