components/gcm_driver/gcm_client.h - Issue 589663004: Setting max TTL for upstream GCM messages to 1 day to match server side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_client.h

Issue 589663004: Setting max TTL for upstream GCM messages to 1 day to match server side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing CL feedback Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/gcm/gcm_apitest.cc ('K') | « chrome/test/data/extensions/api_test/gcm/functions/send/send.js ('k') | components/gcm_driver/gcm_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_client.h

diff --git a/components/gcm_driver/gcm_client.h b/components/gcm_driver/gcm_client.h

index 825c9fd2982ab3553ead6f30ea9a15c798e12cb3..abf2fd5e9bfb8029cab850a37460043ab8d514c7 100644

--- a/components/gcm_driver/gcm_client.h

+++ b/components/gcm_driver/gcm_client.h

@@ -99,7 +99,7 @@ class GCMClient {

int time_to_live;

MessageData data;

- static const int kMaximumTTL = 4 * 7 * 24 * 60 * 60; // 4 weeks.

+ static const int kMaximumTTL;

};

// Message being received from the other party.