chrome/browser/extensions/api/gcm/gcm_apitest.cc - Issue 589663004: Setting max TTL for upstream GCM messages to 1 day to match server side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/gcm/gcm_apitest.cc

Issue 589663004: Setting max TTL for upstream GCM messages to 1 day to match server side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing CL feedback Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/gcm/gcm_apitest.cc

diff --git a/chrome/browser/extensions/api/gcm/gcm_apitest.cc b/chrome/browser/extensions/api/gcm/gcm_apitest.cc

index 0706b2523d9b735db8dc3c6ea7479ad38a9a4be1..b6b07a5bcd8a816ab26aae0fe34dffdd48dee00b 100644

--- a/chrome/browser/extensions/api/gcm/gcm_apitest.cc

+++ b/chrome/browser/extensions/api/gcm/gcm_apitest.cc

@@ -171,7 +171,7 @@ IN_PROC_BROWSER_TEST_F(GcmApiTest, SendMessageDefaultTTL) {

service()->last_sent_message();

gcm::GCMClient::MessageData::const_iterator iter;

- EXPECT_EQ(2419200, message.time_to_live);

+ EXPECT_EQ(gcm::GCMClient::OutgoingMessage::kMaximumTTL, message.time_to_live);

fgorski 2014/09/22 21:12:50 Done. I was initially getting a linker error, but

}

IN_PROC_BROWSER_TEST_F(GcmApiTest, OnMessagesDeleted) {

« no previous file with comments | « no previous file | chrome/common/extensions/api/gcm.json » ('j') | no next file with comments »