chrome/common/extensions/api/gcm.json - Issue 589663004: Setting max TTL for upstream GCM messages to 1 day to match server side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/gcm.json

Issue 589663004: Setting max TTL for upstream GCM messages to 1 day to match server side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing CL feedback Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/gcm/gcm_apitest.cc ('K') | « chrome/browser/extensions/api/gcm/gcm_apitest.cc ('k') | chrome/test/data/extensions/api_test/gcm/functions/send/send.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/gcm.json

diff --git a/chrome/common/extensions/api/gcm.json b/chrome/common/extensions/api/gcm.json

index ec8c5b84834e1f7a45734a91b7e400eb816f54b8..3586292519a22840acc2e06d5f2125f9763b1571 100644

--- a/chrome/common/extensions/api/gcm.json

+++ b/chrome/common/extensions/api/gcm.json

@@ -79,9 +79,9 @@

"timeToLive": {

"type": "integer",

"minimum": 0,

- "maximum": 2419200,

+ "maximum": 86400,

"optional": true,

- "description": "Time-to-live of the message in seconds. If it is not possible to send the message within that time, an onSendError event will be raised. A time-to-live of 0 indicates that the message should be sent immediately or fail if it's not possible. The maximum and a default value of time-to-live is 2419200 seconds (4 weeks)."

+ "description": "Time-to-live of the message in seconds. If it is not possible to send the message within that time, an onSendError event will be raised. A time-to-live of 0 indicates that the message should be sent immediately or fail if it's not possible. The maximum and a default value of time-to-live is 86400 seconds (1 day)."

"data": {

"type": "object",