Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 589403004: Remove page id from ViewHostMsg_UpdateTargetURL; no one actually uses it on the browser side. (Closed)

Created:
6 years, 3 months ago by Avi (use Gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove page id from ViewHostMsg_UpdateTargetURL; no one actually uses it on the browser side. BUG=407376 TEST=no change TBR=ben@chromium.org Committed: https://crrev.com/450ce00e1794787e5886d4fcd329341426242265 Cr-Commit-Position: refs/heads/master@{#296327}

Patch Set 1 #

Patch Set 2 : android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Avi (use Gerrit)
Nasko: IPC Charlie: God I'm an idiot to not have realized this earlier Ben: OWNER ...
6 years, 3 months ago (2014-09-23 22:46:05 UTC) #2
nasko
IPC LGTM
6 years, 3 months ago (2014-09-23 22:48:53 UTC) #3
Charlie Reis
Hah! Emphatic LGTM. Looks like you'll need to remove it from web_contents_delegate_android.{h,cc} as well.
6 years, 3 months ago (2014-09-23 23:39:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589403004/20001
6 years, 3 months ago (2014-09-24 00:28:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17765)
6 years, 3 months ago (2014-09-24 00:33:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589403004/20001
6 years, 3 months ago (2014-09-24 01:30:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 48a632602cb65e2164c2128d2fab62a48a7c9732
6 years, 3 months ago (2014-09-24 01:59:06 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 01:59:40 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/450ce00e1794787e5886d4fcd329341426242265
Cr-Commit-Position: refs/heads/master@{#296327}

Powered by Google App Engine
This is Rietveld 408576698