chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc - Issue 589403004: Remove page id from ViewHostMsg_UpdateTargetURL; no one actually uses it on the browser side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

Issue 589403004: Remove page id from ViewHostMsg_UpdateTargetURL; no one actually uses it on the browser side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

diff --git a/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc b/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

index 98a87b4b39e3a69b34f2b4028a03c4e17ff799cf..ca9377d0c8e07d20fe7209996ce0df9ed54f83ca 100644

--- a/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

+++ b/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

@@ -72,7 +72,7 @@ TEST_F(WebDialogWebContentsDelegateTest, DoNothingMethodsTest) {

test_web_contents_delegate_->ActivateContents(NULL);

test_web_contents_delegate_->LoadingStateChanged(NULL, true);

test_web_contents_delegate_->CloseContents(NULL);

- test_web_contents_delegate_->UpdateTargetURL(NULL, 0, GURL());

+ test_web_contents_delegate_->UpdateTargetURL(NULL, GURL());

test_web_contents_delegate_->MoveContents(NULL, gfx::Rect());

EXPECT_EQ(0, browser()->tab_strip_model()->count());

EXPECT_EQ(1U, chrome::GetTotalBrowserCount());

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | components/web_contents_delegate_android/web_contents_delegate_android.h » ('j') | no next file with comments »