content/browser/web_contents/web_contents_impl.h - Issue 589403004: Remove page id from ViewHostMsg_UpdateTargetURL; no one actually uses it on the browser side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 589403004: Remove page id from ViewHostMsg_UpdateTargetURL; no one actually uses it on the browser side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 5c76a984d54e03ad9cb5a83162a7915e3bde6830..c7a4e25ca4355643ce4298a151dcedcc9d8deeca 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -414,7 +414,7 @@ class CONTENT_EXPORT WebContentsImpl

virtual void UpdateState(RenderViewHost* render_view_host,

int32 page_id,

const PageState& page_state) OVERRIDE;

- virtual void UpdateTargetURL(int32 page_id, const GURL& url) OVERRIDE;

+ virtual void UpdateTargetURL(const GURL& url) OVERRIDE;

virtual void Close(RenderViewHost* render_view_host) OVERRIDE;

virtual void RequestMove(const gfx::Rect& new_bounds) OVERRIDE;

virtual void DidCancelLoading() OVERRIDE;

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »