content/browser/renderer_host/render_view_host_impl.cc - Issue 589403004: Remove page id from ViewHostMsg_UpdateTargetURL; no one actually uses it on the browser side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 589403004: Remove page id from ViewHostMsg_UpdateTargetURL; no one actually uses it on the browser side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 72148fdf7a635ab86e8a9c79e35a434cb07dc84f..6b78d742666d65b1250cd7dc0bf49d84688efca6 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -1094,9 +1094,9 @@ void RenderViewHostImpl::OnUpdateState(int32 page_id, const PageState& state) {

delegate_->UpdateState(this, page_id, state);

}

-void RenderViewHostImpl::OnUpdateTargetURL(int32 page_id, const GURL& url) {

+void RenderViewHostImpl::OnUpdateTargetURL(const GURL& url) {

if (IsRVHStateActive(rvh_state_))

- delegate_->UpdateTargetURL(page_id, url);

+ delegate_->UpdateTargetURL(url);

// Send a notification back to the renderer that we are ready to

// receive more target urls.

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »