Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 589403004: Remove page id from ViewHostMsg_UpdateTargetURL; no one actually uses it on the browser side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 bool* was_blocked) OVERRIDE; 553 bool* was_blocked) OVERRIDE;
554 virtual void ActivateContents(content::WebContents* contents) OVERRIDE; 554 virtual void ActivateContents(content::WebContents* contents) OVERRIDE;
555 virtual void DeactivateContents(content::WebContents* contents) OVERRIDE; 555 virtual void DeactivateContents(content::WebContents* contents) OVERRIDE;
556 virtual void LoadingStateChanged(content::WebContents* source, 556 virtual void LoadingStateChanged(content::WebContents* source,
557 bool to_different_document) OVERRIDE; 557 bool to_different_document) OVERRIDE;
558 virtual void CloseContents(content::WebContents* source) OVERRIDE; 558 virtual void CloseContents(content::WebContents* source) OVERRIDE;
559 virtual void MoveContents(content::WebContents* source, 559 virtual void MoveContents(content::WebContents* source,
560 const gfx::Rect& pos) OVERRIDE; 560 const gfx::Rect& pos) OVERRIDE;
561 virtual bool IsPopupOrPanel( 561 virtual bool IsPopupOrPanel(
562 const content::WebContents* source) const OVERRIDE; 562 const content::WebContents* source) const OVERRIDE;
563 virtual void UpdateTargetURL(content::WebContents* source, int32 page_id, 563 virtual void UpdateTargetURL(content::WebContents* source,
564 const GURL& url) OVERRIDE; 564 const GURL& url) OVERRIDE;
565 virtual void ContentsMouseEvent(content::WebContents* source, 565 virtual void ContentsMouseEvent(content::WebContents* source,
566 const gfx::Point& location, 566 const gfx::Point& location,
567 bool motion) OVERRIDE; 567 bool motion) OVERRIDE;
568 virtual void ContentsZoomChange(bool zoom_in) OVERRIDE; 568 virtual void ContentsZoomChange(bool zoom_in) OVERRIDE;
569 virtual void WebContentsFocused(content::WebContents* content) OVERRIDE; 569 virtual void WebContentsFocused(content::WebContents* content) OVERRIDE;
570 virtual bool TakeFocus(content::WebContents* source, bool reverse) OVERRIDE; 570 virtual bool TakeFocus(content::WebContents* source, bool reverse) OVERRIDE;
571 virtual gfx::Rect GetRootWindowResizerRect() const OVERRIDE; 571 virtual gfx::Rect GetRootWindowResizerRect() const OVERRIDE;
572 virtual void BeforeUnloadFired(content::WebContents* source, 572 virtual void BeforeUnloadFired(content::WebContents* source,
573 bool proceed, 573 bool proceed,
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 958
959 scoped_ptr<chrome::ValidationMessageBubble> validation_message_bubble_; 959 scoped_ptr<chrome::ValidationMessageBubble> validation_message_bubble_;
960 960
961 // The following factory is used to close the frame at a later time. 961 // The following factory is used to close the frame at a later time.
962 base::WeakPtrFactory<Browser> weak_factory_; 962 base::WeakPtrFactory<Browser> weak_factory_;
963 963
964 DISALLOW_COPY_AND_ASSIGN(Browser); 964 DISALLOW_COPY_AND_ASSIGN(Browser);
965 }; 965 };
966 966
967 #endif // CHROME_BROWSER_UI_BROWSER_H_ 967 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698