Show a warning when using sync xhr.

Show a warning when using sync xhr.

This CL shows a message in developer tools console, warning that the sync xhr may
hamper responsiveness.
This was shown as per the spec suggestion: https://xhr.spec.whatwg.org/#sync-warning

BUG=392311
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184788

[Mayur Kankanwadi, 2014-09-19 10:04:15]

mayurk.vk@samsung.com changed reviewers:
+ pdr@chromium.org

[Mayur Kankanwadi, 2014-09-19 10:07:11]

Hi pdr,

This is breaking 385(~1.1%) layout tests, due to the console warning missing
from the expected file of the tests. 
If the fix looks good, in the next patchset I will add all the updated expected
files.

Regards.

On 2014/09/19 10:04:15, Mayur Kankanwadi wrote:
> mailto:mayurk.vk@samsung.com changed reviewers:
> + mailto:pdr@chromium.org

[kouhei (in TOK), 2014-09-19 10:13:12]

kouhei@chromium.org changed reviewers:
+ tyoshino@chromium.org

[kouhei (in TOK), 2014-09-19 10:13:25]

kouhei@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2014-09-19 10:13:26]

lgtm modulo rebaseline

[kouhei (in TOK), 2014-09-19 10:13:54]

On 2014/09/19 10:13:26, kouhei wrote:
> lgtm modulo rebaseline

Please remove [Blink] from patch title.

[tyoshino (SeeGerritForStatus), 2014-09-19 11:03:10]

https://codereview.chromium.org/585873002/diff/1/Source/core/xml/XMLHttpReque...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/585873002/diff/1/Source/core/xml/XMLHttpReque...
Source/core/xml/XMLHttpRequest.cpp:600: , "Avoid synchronous requests as it
hampers user experience due to unresponsiveness of the web page.Refer
https://xhr.spec.whatwg.org/#sync-warning."));
Insert a space between "page." and "Refer"

Please break the line after ",".

[tyoshino (SeeGerritForStatus), 2014-09-19 11:03:33]

cc sof

[Mayur Kankanwadi, 2014-09-19 11:24:18]

Done.
Should I go ahead and start changing the layout tests expected files?

https://codereview.chromium.org/585873002/diff/1/Source/core/xml/XMLHttpReque...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/585873002/diff/1/Source/core/xml/XMLHttpReque...
Source/core/xml/XMLHttpRequest.cpp:600: , "Avoid synchronous requests as it
hampers user experience due to unresponsiveness of the web page.Refer
https://xhr.spec.whatwg.org/#sync-warning."));
On 2014/09/19 11:03:10, tyoshino wrote:
> Insert a space between "page." and "Refer"
> 
> Please break the line after ",".

Done.

[sof, 2014-09-19 14:01:55]

This could potentially add a fair bit of "noise" to the console, for
questionable gain: is there some level of Blink-wide agreement that we want to
do de-"sync XHR" evangelism this way?

[philipj_slow, 2014-09-19 14:23:15]

Looks like sync XHR is used on 3-4% of page loads:
http://www.chromestatus.com/metrics/feature/timeline/popularity/465

Since I've removed some "noisy" deprecation warnings before, I wouldn't mind a
blink-dev discussion about this first.

[pdr., 2014-09-19 17:24:20]

On 2014/09/19 14:01:55, sof wrote:
> This could potentially add a fair bit of "noise" to the console, for
> questionable gain: is there some level of Blink-wide agreement that we want to
> do de-"sync XHR" evangelism this way?

Lets definitely bring this to blink-dev. I'll post on blink-dev later today and
cc everyone here.

[Mayur Kankanwadi, 2014-09-22 06:46:16]

Added code to fire the warning only once for the loaded document.
PTAL.
Thanks.

[kouhei (in TOK), 2014-09-22 06:53:43]

On 2014/09/22 06:46:16, Mayur Kankanwadi wrote:
> Added code to fire the warning only once for the loaded document.
> PTAL.
> Thanks.

I want to avoid once-per-document flag if possible. Duplicated warning messages
are deduped in Devtools console, so I think we are fine printing the warning
every time.

[Mayur Kankanwadi, 2014-09-22 06:58:41]

@kouhei: Thanks for the reply.
In the layout tests , there will be a console warning added for each sync xhr
fired. 
Should we care about them?
This discussion
thread(https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7nKMdg_ALcc)

started by pdr, seems to be heading this way. Hence made the changes in advance.

[kouhei (in TOK), 2014-09-22 07:49:12]

On 2014/09/22 06:58:41, Mayur Kankanwadi wrote:
> @kouhei: Thanks for the reply.
> In the layout tests , there will be a console warning added for each sync xhr
> fired. 
> Should we care about them?
> This discussion
>
thread(https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7nKMdg_ALcc)
> 
> started by pdr, seems to be heading this way. Hence made the changes in
advance.

Duplicated lines in LayoutTests result are fine IMO.

[pdr., 2014-09-22 20:58:34]

I was hoping there'd be more discussion on the blink-dev post. Lets wait a few
days to see if others chime in.

I think we should try to match Gecko here. I think this means showing the
warning once per page except if:
*) the request was made in an onbeforeunload handler.
*) the request was made in a worker thread.

[Mayur Kankanwadi, 2014-09-29 06:36:10]

On 2014/09/22 20:58:34, pdr wrote:
> I was hoping there'd be more discussion on the blink-dev post. Lets wait a few
> days to see if others chime in.
> 
> I think we should try to match Gecko here. I think this means showing the
> warning once per page except if:
> *) the request was made in an onbeforeunload handler.
> *) the request was made in a worker thread.

There has been some wonderful discussion going on in blink-dev, but the decision

about our course ahead still remains a mystery.
Can we have some decision on it?

[mlamouri (slow - plz ping), 2014-09-29 10:56:59]

On 2014/09/29 06:36:10, Mayur Kankanwadi wrote:
> On 2014/09/22 20:58:34, pdr wrote:
> > I was hoping there'd be more discussion on the blink-dev post. Lets wait a
few
> > days to see if others chime in.
> > 
> > I think we should try to match Gecko here. I think this means showing the
> > warning once per page except if:
> > *) the request was made in an onbeforeunload handler.
> > *) the request was made in a worker thread.
> 
> There has been some wonderful discussion going on in blink-dev, but the
decision
> 
> about our course ahead still remains a mystery.
> Can we have some decision on it?

I think pdr@ recommendations are a good conclusion.

[Mayur Kankanwadi, 2014-10-01 11:12:55]

On 2014/09/29 10:56:59, Mounir Lamouri wrote:
> On 2014/09/29 06:36:10, Mayur Kankanwadi wrote:
> > On 2014/09/22 20:58:34, pdr wrote:
> > > I was hoping there'd be more discussion on the blink-dev post. Lets wait a
> few
> > > days to see if others chime in.
> > > 
> > > I think we should try to match Gecko here. I think this means showing the
> > > warning once per page except if:
> > > *) the request was made in an onbeforeunload handler.
> > > *) the request was made in a worker thread.
> > 
> > There has been some wonderful discussion going on in blink-dev, but the
> decision
> > 
> > about our course ahead still remains a mystery.
> > Can we have some decision on it?
> 
> I think pdr@ recommendations are a good conclusion.

Hi all,
PTAL to the updated patch.
I have added the code for the above two conditions.
Thanks.

[kouhei (in TOK), 2014-10-01 11:38:45]

Please ignore my last lg tm for now since the patch has changed a lot.

https://codereview.chromium.org/585873002/diff/80001/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/585873002/diff/80001/Source/core/dom/Document...
Source/core/dom/Document.h:1378: bool m_warnAboutSyncXHROnce;
m_hasWarnedAboutSyncXHR?

I want to avoid adding the flag in Document as much as possible, but I don't
have a suggestion of alternative now...

https://codereview.chromium.org/585873002/diff/80001/Source/core/dom/Executio...
File Source/core/dom/ExecutionContext.h (right):

https://codereview.chromium.org/585873002/diff/80001/Source/core/dom/Executio...
Source/core/dom/ExecutionContext.h:134: virtual void setIsBeforeUnloadEvent(bool
inBeforeUnloadEvent) { m_inBeforeUnloadEvent = inBeforeUnloadEvent; }
Can you use lifecycle methods in Document instead?

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Mike West, 2014-10-01 12:00:41]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2014-10-01 12:00:44]

Not LGTM. Please deal with deduplication by using 'UseCounter::countDeprecation'
rather than the document-level flags.

https://codereview.chromium.org/585873002/diff/80001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/585873002/diff/80001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:597: if
(!executionContext()->inBeforeUnloadEvent() &&
!document()->didWarnAboutSyncXHROnce()) {
You can avoid the "didWarnAbout..." flag by using UseCounter::countDeprecation.
In fact, there's already a counter defined for this:
'XMLHttpRequestSynchronous', and it's triggered in
XMLHttpRequest::createRequest:884.

I'd suggest modifying that callsite to use '::countDeprecation()' rather than
'::count()', and adding your deprecation message to the list in
'UseCounter::deprecationMessage'.

[Mayur Kankanwadi, 2014-10-06 12:47:41]

On 2014/10/01 12:00:44, Mike West wrote:
> Not LGTM. Please deal with deduplication by using
'UseCounter::countDeprecation'
> rather than the document-level flags.
> 
>
https://codereview.chromium.org/585873002/diff/80001/Source/core/xml/XMLHttpR...
> File Source/core/xml/XMLHttpRequest.cpp (right):
> 
>
https://codereview.chromium.org/585873002/diff/80001/Source/core/xml/XMLHttpR...
> Source/core/xml/XMLHttpRequest.cpp:597: if
> (!executionContext()->inBeforeUnloadEvent() &&
> !document()->didWarnAboutSyncXHROnce()) {
> You can avoid the "didWarnAbout..." flag by using
UseCounter::countDeprecation.
> In fact, there's already a counter defined for this:
> 'XMLHttpRequestSynchronous', and it's triggered in
> XMLHttpRequest::createRequest:884.
> 
> I'd suggest modifying that callsite to use '::countDeprecation()' rather than
> '::count()', and adding your deprecation message to the list in
> 'UseCounter::deprecationMessage'.

Hi Mike,kouhei,
Incorporated the review comments added by you.
PTAL.
Thanks.

[Mayur Kankanwadi, 2014-10-06 12:48:16]

Hi Mike,kouhei,
Incorporated the review comments added by you.
PTAL.
Thanks.

https://codereview.chromium.org/585873002/diff/80001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/585873002/diff/80001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:597: if
(!executionContext()->inBeforeUnloadEvent() &&
!document()->didWarnAboutSyncXHROnce()) {
On 2014/10/01 12:00:44, Mike West wrote:
> You can avoid the "didWarnAbout..." flag by using
UseCounter::countDeprecation.
> In fact, there's already a counter defined for this:
> 'XMLHttpRequestSynchronous', and it's triggered in
> XMLHttpRequest::createRequest:884.
> 
> I'd suggest modifying that callsite to use '::countDeprecation()' rather than
> '::count()', and adding your deprecation message to the list in
> 'UseCounter::deprecationMessage'.

Done.

[kouhei (in TOK), 2014-10-07 23:21:18]

https://codereview.chromium.org/585873002/diff/120001/Source/bindings/core/v8...
File Source/bindings/core/v8/V8AbstractEventListener.cpp (right):

https://codereview.chromium.org/585873002/diff/120001/Source/bindings/core/v8...
Source/bindings/core/v8/V8AbstractEventListener.cpp:126: tryCatch.Reset();
Undo this change.

https://codereview.chromium.org/585873002/diff/120001/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/585873002/diff/120001/Source/core/dom/Documen...
Source/core/dom/Document.h:903: bool processingBeforeUnload() const { return
m_loadEventProgress == BeforeUnloadEventInProgress; }
Please don't add a new one. I think we can use !unloadStarted() instead?

https://codereview.chromium.org/585873002/diff/120001/Source/core/frame/UseCo...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/585873002/diff/120001/Source/core/frame/UseCo...
Source/core/frame/UseCounter.cpp:796: return "Synchronous XMLHttpRequest is
deprecated. Please use the async version.";
Is "deprecated" the message we want to show here? May be only mention about
speed?

https://codereview.chromium.org/585873002/diff/120001/Source/core/xml/XMLHttp...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/585873002/diff/120001/Source/core/xml/XMLHttp...
Source/core/xml/XMLHttpRequest.cpp:598: if
(!document()->processingBeforeUnload())
Ditto: !unloadStarted() ?

https://codereview.chromium.org/585873002/diff/120001/Source/core/xml/XMLHttp...
Source/core/xml/XMLHttpRequest.cpp:599:
UseCounter::countDeprecation(executionContext(),
UseCounter::XMLHttpRequestSynchronous);
I don't think we should move callsite of existing UseCounter, as then we would
get mixed results from Chrome before/after this change. Use a new one?

https://codereview.chromium.org/585873002/diff/120001/Source/core/xml/XMLHttp...
Source/core/xml/XMLHttpRequest.cpp:889: } else
Ditto

[Mayur Kankanwadi, 2014-10-08 10:14:25]

kouhei,
Thanks for the review.
PTAL at my comments.
Regards.

https://codereview.chromium.org/585873002/diff/120001/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/585873002/diff/120001/Source/core/dom/Documen...
Source/core/dom/Document.h:903: bool processingBeforeUnload() const { return
m_loadEventProgress == BeforeUnloadEventInProgress; }
On 2014/10/07 23:21:18, kouhei wrote:
> Please don't add a new one. I think we can use !unloadStarted() instead?
unloadStarted even includes PageHideInProgress, which will be processing
pagehide event. We want to handle beforeunload only. Hence the new function was
added to specifically handle beforeunload event.

https://codereview.chromium.org/585873002/diff/120001/Source/core/frame/UseCo...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/585873002/diff/120001/Source/core/frame/UseCo...
Source/core/frame/UseCounter.cpp:796: return "Synchronous XMLHttpRequest is
deprecated. Please use the async version.";
On 2014/10/07 23:21:18, kouhei wrote:
> Is "deprecated" the message we want to show here? May be only mention about
> speed?
I assumed with UseCounter::countDeprecation function coming into picture, the
current course is to inform the user that sync xhr on main thread is deprecated
(usage "not encouraged", with the view of removing functionality in the
future(5-10 yrs!!)).

https://codereview.chromium.org/585873002/diff/120001/Source/core/xml/XMLHttp...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/585873002/diff/120001/Source/core/xml/XMLHttp...
Source/core/xml/XMLHttpRequest.cpp:599:
UseCounter::countDeprecation(executionContext(),
UseCounter::XMLHttpRequestSynchronous);
On 2014/10/07 23:21:18, kouhei wrote:
> I don't think we should move callsite of existing UseCounter, as then we would
> get mixed results from Chrome before/after this change. Use a new one?
If we use UseCounter::countDeprecation here, then the subsequent
UseCounter::count asserts. So the option was to remove this call and let the
below UseCounter::count to continue. 
But then we want to show the deprecation message only for main thread sync xhr,
worker thread sync xhr's are fine. 
Should we add one more counter like XMLHttpRequestSynchronousInWorker? So that
we can account for sync xhr's in all scenarios, probably in another CL!!

[Mike West, 2014-10-08 10:18:04]

Can we just use the same text as Firefox for this warning?

Code change LGTM, modulo kouhei@'s comments. I'll defer the rest of the review
to him.

[Mayur Kankanwadi, 2014-10-08 10:44:08]

On 2014/10/08 10:18:04, Mike West wrote:
> Can we just use the same text as Firefox for this warning?
> 
> Code change LGTM, modulo kouhei@'s comments. I'll defer the rest of the review
> to him.

Thanks Mike.

[kouhei (in TOK), 2014-10-09 06:45:46]

https://codereview.chromium.org/585873002/diff/120001/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/585873002/diff/120001/Source/core/dom/Documen...
Source/core/dom/Document.h:903: bool processingBeforeUnload() const { return
m_loadEventProgress == BeforeUnloadEventInProgress; }
On 2014/10/08 10:14:24, Mayur Kankanwadi wrote:
> On 2014/10/07 23:21:18, kouhei wrote:
> > Please don't add a new one. I think we can use !unloadStarted() instead?
> unloadStarted even includes PageHideInProgress, which will be processing
> pagehide event. We want to handle beforeunload only. Hence the new function
was
> added to specifically handle beforeunload event.
> 

Acknowledged.

[Mayur Kankanwadi, 2014-10-09 14:37:55]

https://codereview.chromium.org/585873002/diff/120001/Source/bindings/core/v8...
File Source/bindings/core/v8/V8AbstractEventListener.cpp (right):

https://codereview.chromium.org/585873002/diff/120001/Source/bindings/core/v8...
Source/bindings/core/v8/V8AbstractEventListener.cpp:126: tryCatch.Reset();
On 2014/10/07 23:21:18, kouhei wrote:
> Undo this change.

Done.

[Mayur Kankanwadi, 2014-10-13 12:30:48]

Hi kouhei,
Do the changes LGT you?
Any other changes to be incorporated?
Thanks.

[pdr., 2014-10-13 17:30:07]

This looks good to me. Please wait for Kouhei's LGTM as well.

[kouhei (in TOK), 2014-10-14 05:08:49]

Sorry, not lgtm yet.

https://codereview.chromium.org/585873002/diff/140001/Source/core/frame/UseCo...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/585873002/diff/140001/Source/core/frame/UseCo...
Source/core/frame/UseCounter.cpp:796: return "Synchronous XMLHttpRequest is
deprecated. Please use the async version.";
As Mike said, please use the same text as Firefox for this warning.

https://codereview.chromium.org/585873002/diff/140001/Source/core/xml/XMLHttp...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/585873002/diff/140001/Source/core/xml/XMLHttp...
Source/core/xml/XMLHttpRequest.cpp:599:
UseCounter::countDeprecation(executionContext(),
UseCounter::XMLHttpRequestSynchronous);
I'm still worried about this change. This will break the current use counter, so
I would add a new one to avoid troubles.

The old one was measured at send(), and this one is measured at open().

[Mayur Kankanwadi, 2014-10-16 07:19:40]

On 2014/10/14 05:08:49, kouhei wrote:
> Sorry, not lgtm yet.
> 
>
https://codereview.chromium.org/585873002/diff/140001/Source/core/frame/UseCo...
> File Source/core/frame/UseCounter.cpp (right):
> 
>
https://codereview.chromium.org/585873002/diff/140001/Source/core/frame/UseCo...
> Source/core/frame/UseCounter.cpp:796: return "Synchronous XMLHttpRequest is
> deprecated. Please use the async version.";
> As Mike said, please use the same text as Firefox for this warning.
> 
>
https://codereview.chromium.org/585873002/diff/140001/Source/core/xml/XMLHttp...
> File Source/core/xml/XMLHttpRequest.cpp (right):
> 
>
https://codereview.chromium.org/585873002/diff/140001/Source/core/xml/XMLHttp...
> Source/core/xml/XMLHttpRequest.cpp:599:
> UseCounter::countDeprecation(executionContext(),
> UseCounter::XMLHttpRequestSynchronous);
> I'm still worried about this change. This will break the current use counter,
so
> I would add a new one to avoid troubles.
> 
> The old one was measured at send(), and this one is measured at open().

Hi kouhei,
Thanks for the review.
Do you suggest adding the new counter in a new CL(new bug, new CL) or in the
current one itself?
I propose to add a XMLHttpRequestSynchronousInMainThread entry in the
UseCounter::Feature enum 
and then call countDeprecation on it at line XMLHttpRequest.cpp:599.
Does it sound right?
I will complete the rest of the suggested changes.
Thanks.

[kouhei (in TOK), 2014-10-16 09:17:33]

> Do you suggest adding the new counter in a new CL(new bug, new CL) or in the
> current one itself?
I would add it in this CL.
If you choose to do it in a separate CL, be sure to land the UseCounter CL first
and land this afterwards The current UseCounter will break otherwise.

> I propose to add a XMLHttpRequestSynchronousInMainThread entry in the
> UseCounter::Feature enum 
> and then call countDeprecation on it at line XMLHttpRequest.cpp:599.
> Does it sound right?
I think it should be XMLHttpRequestSynchronousOutsideUnloadEvent or something. I
don't think "InMainThread" is important here.

[Mayur Kankanwadi, 2014-10-17 07:21:09]

Hi kouhei,
PTAL, I have added a new counter for SJAX.
The old counter is untouched.
Thanks.

[kouhei (in TOK), 2014-10-17 08:49:45]

lgtm

[Mayur Kankanwadi, 2014-10-17 09:12:00]

On 2014/10/17 08:49:45, kouhei wrote:
> lgtm

Thanks a lot. :)

[Mayur Kankanwadi, 2014-10-17 09:12:21]

The CQ bit was checked by mayurk.vk@samsung.com

[commit-bot: I haz the power, 2014-10-17 09:13:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585873002/200001

[commit-bot: I haz the power, 2014-10-17 09:15:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-17 09:15:16]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 535.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
6829f7ee57db49860bda347a278b03cd47959013..b26a8d4ce7362cb14169c61089a9be1eb0f9f0be
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -535,6 +535,7 @@ public:
         NotificationInsecureOrigin = 564,
         NotificationShowEvent = 565,
         CSSXGetComputedStyleQueries = 566,
+        XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload = 567,
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.
         // Also, run update_use_counter_feature_enum.py in
chromium/src/tools/metrics/histograms/

[tyoshino (SeeGerritForStatus), 2014-10-22 11:13:42]

lgtm

You just need to update UseCounter.h not to conflict with newly added enums.

[Mayur Kankanwadi, 2014-10-27 08:24:15]

The CQ bit was checked by mayurk.vk@samsung.com

[commit-bot: I haz the power, 2014-10-27 08:24:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585873002/240001

[commit-bot: I haz the power, 2014-10-27 09:35:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-27 09:35:59]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[Mayur Kankanwadi, 2014-10-28 07:22:07]

On 2014/10/27 09:35:59, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

Hi tyoshino, kouhei,
I have added 3 more expected.txt files after the layout tests failed.
I missed these files completely.
The following files were added :
--
LayoutTests/css-parser/color3-expected.txt
LayoutTests/fast/dom/cross-frame-accessor-throw-expected.txt
LayoutTests/http/tests/serviceworker/sync-xhr-doesnt-deadlock-expected.txt
--
Adding these will fix the layout test failures.
Sorry, for bothering you for one last round of review.
PTAL.
Regards.

[tyoshino (SeeGerritForStatus), 2014-10-28 07:59:12]

On 2014/10/28 07:22:07, (OoO)Mayur Kankanwadi wrote:
> On 2014/10/27 09:35:59, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   linux_blink_rel on tryserver.blink
> >
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)
> 
> Hi tyoshino, kouhei,
> I have added 3 more expected.txt files after the layout tests failed.
> I missed these files completely.
> The following files were added :
> --
> LayoutTests/css-parser/color3-expected.txt
> LayoutTests/fast/dom/cross-frame-accessor-throw-expected.txt
> LayoutTests/http/tests/serviceworker/sync-xhr-doesnt-deadlock-expected.txt
> --
> Adding these will fix the layout test failures.
> Sorry, for bothering you for one last round of review.
> PTAL.
> Regards.

lgtm

[Mayur Kankanwadi, 2014-10-28 08:32:06]

The CQ bit was checked by mayurk.vk@samsung.com

[commit-bot: I haz the power, 2014-10-28 08:32:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585873002/260001

[commit-bot: I haz the power, 2014-10-28 10:17:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-28 10:17:28]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/28777)

[Mayur Kankanwadi, 2014-10-29 06:30:59]

On 2014/10/28 10:17:28, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_blink_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/28777)
Hi,
This time the bots failed for mac and win.
Have added the NeedsRebaseline for those tests in the TestExpectations file.
PTAL.
Regards.

[tyoshino (SeeGerritForStatus), 2014-10-29 06:49:05]

lgtm

https://codereview.chromium.org/585873002/diff/280001/LayoutTests/TestExpecta...
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/585873002/diff/280001/LayoutTests/TestExpecta...
LayoutTests/TestExpectations:1484: #This batch is for the sync xhr console log
patch.
space between # and This

https://codereview.chromium.org/585873002/diff/280001/LayoutTests/TestExpecta...
LayoutTests/TestExpectations:1492: crbug.com/392311 [ Mac ]
http/tests/xmlhttprequest/origin-exact-matching/36.html [ NeedsRebaseline ]
I see. They're expected to fail on Win by the entries above. For Linux, we have
platform specific expectations in
LayoutTests/platform/linux/http/tests/xmlhttprequest/.

[Mayur Kankanwadi, 2014-10-29 07:35:46]

The CQ bit was checked by mayurk.vk@samsung.com

[commit-bot: I haz the power, 2014-10-29 07:36:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585873002/300001

[commit-bot: I haz the power, 2014-10-29 07:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-29 07:38:25]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 546.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
e86def6ec4f9d1960bbdf4e3e0bdcee56a72322a..9c74fc3fa3d7b14d4f92cbc399a31c543417e5ba
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -546,6 +546,7 @@ public:
 
         WindowPostMessage = 574,
         WindowPostMessageWithLegacyTargetOriginArgument = 575,
+        XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload = 576,
 
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.

[Mayur Kankanwadi, 2014-10-30 06:22:16]

The CQ bit was unchecked by mayurk.vk@samsung.com

[Mayur Kankanwadi, 2014-10-30 06:22:16]

The CQ bit was checked by mayurk.vk@samsung.com

[commit-bot: I haz the power, 2014-10-30 06:22:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585873002/320001

[commit-bot: I haz the power, 2014-10-30 07:44:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 07:44:27]

Failed to apply patch for Source/core/xml/XMLHttpRequest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/core/xml/XMLHttpRequest.cpp
  |diff --git a/Source/core/xml/XMLHttpRequest.cpp
b/Source/core/xml/XMLHttpRequest.cpp
  |index
8764c90e7e655ecd10b4156c0e8a8906c86a152b..99fe10e9052b767a0d64c3d4f515b58b9520b09c
100644
  |--- a/Source/core/xml/XMLHttpRequest.cpp
  |+++ b/Source/core/xml/XMLHttpRequest.cpp
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       Source/core/xml/XMLHttpRequest.cpp
Index: Source/core/xml/XMLHttpRequest.cpp
diff --git a/Source/core/xml/XMLHttpRequest.cpp
b/Source/core/xml/XMLHttpRequest.cpp
index
8764c90e7e655ecd10b4156c0e8a8906c86a152b..99fe10e9052b767a0d64c3d4f515b58b9520b09c
100644
--- a/Source/core/xml/XMLHttpRequest.cpp
+++ b/Source/core/xml/XMLHttpRequest.cpp
@@ -608,6 +608,13 @@ void XMLHttpRequest::open(const AtomicString& method, const
KURL& url, bool asyn
             exceptionState.throwDOMException(InvalidAccessError, "Synchronous
requests must not set a timeout.");
             return;
         }
+
+        // Here we just warn that firing sync XHR's may affect responsiveness.
+        // Eventually sync xhr will be deprecated and an "InvalidAccessError"
exception thrown.
+        // Refer : https://xhr.spec.whatwg.org/#sync-warning
+        // Use count for XHR synchronous requests on main thread only.
+        if (!document()->processingBeforeUnload())
+            UseCounter::countDeprecation(executionContext(),
UseCounter::XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload);
     }
 
     m_method = FetchUtils::normalizeMethod(method);

[Mayur Kankanwadi, 2014-10-31 12:32:34]

The CQ bit was unchecked by mayurk.vk@samsung.com

[Mayur Kankanwadi, 2014-10-31 12:32:34]

The CQ bit was checked by mayurk.vk@samsung.com

[commit-bot: I haz the power, 2014-10-31 12:33:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585873002/340001

[commit-bot: I haz the power, 2014-10-31 12:35:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-31 12:35:29]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1518.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
b04533a2fa956314db7a8cd88aaf3cb55b1e2d0c..9a8431ea7246d17b0252b083eff3d31f852cc348
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1518,3 +1518,13 @@ crbug.com/401377 [ Win Release ]
http/tests/serviceworker/fetch-mixed-content-to
 crbug.com/401377 [ Win Release ]
http/tests/serviceworker/fetch-mixed-content-to-outscope.html [ Pass Timeout ]
 
 crbug.com/426078 [ Win7 ]
http/tests/security/img-crossorigin-no-credentials-prompt.html [ Pass Timeout ]
+
+# This batch is for the sync xhr console log patch.
+crbug.com/392311 [ Mac Win Release ] http/tests/appcache/fallback.html [
NeedsRebaseline ]
+crbug.com/392311 [ Mac Win Release ]
http/tests/plugins/third-party-cookie-accept-policy.html [ NeedsRebaseline ]
+crbug.com/392311 [ Mac ]
http/tests/xmlhttprequest/origin-exact-matching/22.html [ NeedsRebaseline ]
+crbug.com/392311 [ Mac ]
http/tests/xmlhttprequest/origin-exact-matching/27.html [ NeedsRebaseline ]
+crbug.com/392311 [ Mac ]
http/tests/xmlhttprequest/origin-exact-matching/28.html [ NeedsRebaseline ]
+crbug.com/392311 [ Mac ]
http/tests/xmlhttprequest/origin-exact-matching/29.html [ NeedsRebaseline ]
+crbug.com/392311 [ Mac ]
http/tests/xmlhttprequest/origin-exact-matching/30.html [ NeedsRebaseline ]
+crbug.com/392311 [ Mac ]
http/tests/xmlhttprequest/origin-exact-matching/36.html [ NeedsRebaseline ]

[Mayur Kankanwadi, 2014-11-02 09:14:41]

The CQ bit was checked by mayurk.vk@samsung.com

[commit-bot: I haz the power, 2014-11-02 09:15:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585873002/360001

[commit-bot: I haz the power, 2014-11-02 09:17:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-02 09:17:34]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1.
  Hunk #2 succeeded at 17 (offset -2 lines).
  Hunk #3 succeeded at 35 (offset -2 lines).
  Hunk #4 succeeded at 154 (offset -2 lines).
  Hunk #5 succeeded at 392 (offset -6 lines).
  Hunk #6 succeeded at 405 (offset -6 lines).
  Hunk #7 succeeded at 736 (offset -3 lines).
  Hunk #8 succeeded at 936 (offset -3 lines).
  Hunk #9 succeeded at 959 (offset -3 lines).
  Hunk #10 succeeded at 1009 (offset -3 lines).
  Hunk #11 succeeded at 1017 (offset -3 lines).
  Hunk #12 succeeded at 1030 (offset -3 lines).
  Hunk #13 succeeded at 1220 (offset -3 lines).
  Hunk #14 succeeded at 1294 (offset -3 lines).
  Hunk #15 succeeded at 1361 (offset -3 lines).
  Hunk #16 FAILED at 1464.
  Hunk #17 succeeded at 1541 (offset -5 lines).
  2 out of 17 hunks FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
30c934386c478a783ccd9575221e2d6c55055f97..7d6bb13caadd612442263bb29a31a46cf6373857
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1,5 +1,3 @@
-crbug.com/423707 compositing/gestures/gesture-tapHighlight-with-squashing.html
[ NeedsRebaseline ]
-
 # This directly has manual tests that don't have to run with run-webkit-tests
 crbug.com/359838 http/tests/ManualTests/ [ Skip ]
 
@@ -19,6 +17,7 @@ crbug.com/437743
virtual/slimmingpaint/fast/block/line-layout/selection-highligh
 crbug.com/437743
virtual/slimmingpaint/fast/block/lineboxcontain/block-font.html [
ImageOnlyFailure ]
 crbug.com/437743
virtual/slimmingpaint/fast/block/lineboxcontain/block-glyphs-replaced.html [
ImageOnlyFailure ]
 crbug.com/437743
virtual/slimmingpaint/fast/block/lineboxcontain/block-glyphs.html [
ImageOnlyFailure ]
+crbug.com/437743
virtual/slimmingpaint/fast/block/lineboxcontain/block-with-ideographs.xhtml [
ImageOnlyFailure ]
 crbug.com/437743
virtual/slimmingpaint/fast/block/lineboxcontain/font-replaced.html [
ImageOnlyFailure ]
 crbug.com/437743 virtual/slimmingpaint/fast/block/lineboxcontain/font.html [
ImageOnlyFailure ]
 crbug.com/437743 virtual/slimmingpaint/fast/block/lineboxcontain/glyphs.html [
ImageOnlyFailure ]
@@ -36,7 +35,7 @@ crbug.com/321460 animations/animation-direction-normal.html [
Pass ImageOnlyFail
 
 crbug.com/328996 [ Mac Debug ] http/tests/media/video-seek-to-middle.html [
Pass Failure ]
 
-crbug.com/427953 [ Lion MountainLion Retina Mavericks ]
fast/css/invalidation/scrollbar-pseudo-classes.html [ ImageOnlyFailure ]
+crbug.com/427953 [ Mac ] fast/css/invalidation/scrollbar-pseudo-classes.html [
ImageOnlyFailure ]
 
 # This test is slow due to Mesa slowness.
 crbug.com/244481 virtual/gpu/canvas/philip/tests/2d.shadow.blur.low.html [ Skip
]
@@ -155,8 +154,8 @@ crbug.com/360889
fast/dom/HTMLDialogElement/dialog-scrolled-viewport.html [ Fail
 crbug.com/360889 crbug.com/399417 media/video-scales-in-media-document.html [
Failure Crash ]
 crbug.com/360889 [ Win ] fast/css/css3-ch-unit.html [ Failure ]
 crbug.com/360889 [ Win ]
fast/text/whitespace/nowrap-line-break-after-white-space.html [ Failure ]
-crbug.com/360889 [ Win ]
virtual/antialiasedtext/fast/text/whitespace/nowrap-line-break-after-white-space.html
[ Failure ]
-crbug.com/360889 [ Win ]
virtual/textblob/fast/text/whitespace/nowrap-line-break-after-white-space.html [
Failure ]
+crbug.com/360889
virtual/antialiasedtext/fast/text/whitespace/nowrap-line-break-after-white-space.html
[ Failure ]
+crbug.com/360889
virtual/textblob/fast/text/whitespace/nowrap-line-break-after-white-space.html [
Failure ]
 
 crbug.com/418884 [ Win7 ]
virtual/antialiasedtext/fast/text/emphasis-combined-text.html [ Failure ]
 
@@ -397,11 +396,11 @@ crbug.com/232061 [ Linux ]
virtual/textblob/fast/text/zero-font-size-2.html [ Im
 crbug.com/378610 [ Win7 ] fast/writing-mode/table-vertical-child-width.html [
ImageOnlyFailure ]
 crbug.com/396940 ietestcenter/css3/multicolumn/column-containing-block-001.htm
[ ImageOnlyFailure ]
 crbug.com/396940 ietestcenter/css3/multicolumn/column-containing-block-002.htm
[ ImageOnlyFailure ]
-crbug.com/396941 [ Linux Win ]
ietestcenter/css3/multicolumn/column-width-applies-to-007.htm [ ImageOnlyFailure
]
-crbug.com/396941 [ Linux Win ]
ietestcenter/css3/multicolumn/column-width-applies-to-009.htm [ ImageOnlyFailure
]
-crbug.com/396941 [ Linux Win ]
ietestcenter/css3/multicolumn/column-width-applies-to-010.htm [ ImageOnlyFailure
]
-crbug.com/396941 [ Linux Win ]
ietestcenter/css3/multicolumn/column-width-applies-to-012.htm [ ImageOnlyFailure
]
-crbug.com/396941 [ Linux Win ]
ietestcenter/css3/multicolumn/column-width-applies-to-015.htm [ ImageOnlyFailure
]
+crbug.com/396941 ietestcenter/css3/multicolumn/column-width-applies-to-007.htm
[ ImageOnlyFailure ]
+crbug.com/396941 ietestcenter/css3/multicolumn/column-width-applies-to-009.htm
[ ImageOnlyFailure ]
+crbug.com/396941 ietestcenter/css3/multicolumn/column-width-applies-to-010.htm
[ ImageOnlyFailure ]
+crbug.com/396941 ietestcenter/css3/multicolumn/column-width-applies-to-012.htm
[ ImageOnlyFailure ]
+crbug.com/396941 ietestcenter/css3/multicolumn/column-width-applies-to-015.htm
[ ImageOnlyFailure ]
 crbug.com/396945 ietestcenter/css3/namespaces/syntax-021.xml [ ImageOnlyFailure
]
 crbug.com/378610 [ Win7 ] svg/transforms/transformed-text-fill-gradient.html [
ImageOnlyFailure ]
 crbug.com/378610 [ Win7 ] svg/custom/focus-ring-text.svg [ ImageOnlyFailure ]
@@ -410,10 +409,15 @@ crbug.com/371725 http/tests/webfont/slow-loading.html [
Pass ImageOnlyFailure Ti
 
 # Issues on the mac-antialiased fonts virtual test suite.
 # crbug.com/367074 [ Mac ]
virtual/antialiasedtext/fast/text/sub-pixel/text-scaling-pixel.html [ Skip ]
+crbug.com/334269 [ Mac ]
virtual/antialiasedtext/fast/text/font-variant-ligatures.html [ ImageOnlyFailure
]
 crbug.com/334269 [ Mac ]
virtual/antialiasedtext/fast/text/international/zerowidthjoiner.html [
ImageOnlyFailure ]
 crbug.com/334269 [ Mac ]
virtual/textblob/fast/text/international/zerowidthjoiner.html [ ImageOnlyFailure
]
+crbug.com/334269 [ Mac ]
virtual/antialiasedtext/fast/text/international/bdo-bidi-width.html [
ImageOnlyFailure ]
 crbug.com/290411 [ Mac ]
virtual/antialiasedtext/fast/text/sub-pixel/text-scaling-pixel.html [ Skip ]
 
+crbug.com/334269 [ Mac ] fast/text/international/bdo-bidi-width.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ] fast/text/font-variant-ligatures.html [
ImageOnlyFailure ]
+
 crbug.com/393157 [ Mac ]
virtual/threaded/printing/print-document-without-documentElement-crash.html [
Pass Crash ]
 
 # Switching to content shell failures
@@ -733,27 +737,51 @@ crbug.com/418070 [ Mac ]
fast/text/atsui-multiple-renderers.html [ Failure ]
 crbug.com/418070 [ Mac ]
virtual/textblob/fast/text/atsui-multiple-renderers.html [ Failure ]
 
 # Failing Reftests from CoreText shaper removal
+crbug.com/334269 [ Mac ] animations/additive-transform-animations.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ]
compositing/backgrounds/fixed-background-on-descendant.html [ ImageOnlyFailure ]
 crbug.com/334269 [ Mac ] css2.1/20110323/c541-word-sp-000.htm [
ImageOnlyFailure ]
 crbug.com/334269 [ Mac ] css2.1/20110323/vertical-align-boxes-001.htm [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ] css2.1/20110323/word-spacing-characters-003.htm [
ImageOnlyFailure ]
 crbug.com/334269 [ Mac ] css3/flexbox/auto-margins.html [ ImageOnlyFailure ]
+crbug.com/334269 [ Mac ] fast/forms/placeholder-in-invisible-elements.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ] fast/forms/search-cancel-in-invisible-elements.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ]
fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html
[ ImageOnlyFailure ]
 crbug.com/334269 [ Mac ]
fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-auto-height.html
[ ImageOnlyFailure ]
 crbug.com/334269 [ Mac ]
fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-fixed-height.html
[ ImageOnlyFailure ]
 crbug.com/334269 [ Mac ]
fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol.html
[ ImageOnlyFailure ]
+crbug.com/334269 [ Mac ]
fast/scrolling/non-composited-scrolling-repaint-local-background.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ] fast/sub-pixel/input-caret-on-subpixel-bound.html [
ImageOnlyFailure ]
 crbug.com/334269 [ Mac ] fast/table/td-width-fifty-percent-regression.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ]
fast/text-autosizing/form-controls-autosizing-fieldset-element.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ]
fast/text-autosizing/list-marker-with-images-and-forms-autosizing.html [
ImageOnlyFailure ]
 crbug.com/334269 [ Mac ]
fast/text-autosizing/list-marker-with-links-autosizing.html [ ImageOnlyFailure ]
 crbug.com/334269 [ Mac ]
fast/text/international/complex-text-missing-glyph-fallback.html [
ImageOnlyFailure ]
 crbug.com/334269 [ Mac ]
virtual/textblob/fast/text/international/complex-text-missing-glyph-fallback.html
[ ImageOnlyFailure ]
+crbug.com/334269 [ Mac ]
fast/text/international/complex-text-space-in-second-font.html [
ImageOnlyFailure ]
 crbug.com/334269 [ Mac ]
fast/text/international/vertical-positioning-with-combining-marks.html [
ImageOnlyFailure ]
 crbug.com/334269 [ Mac ]
virtual/textblob/fast/text/international/vertical-positioning-with-combining-marks.html
[ ImageOnlyFailure ]
 crbug.com/334269 [ Mac ] fast/writing-mode/table-vertical-child-width.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ] fullscreen/full-screen-fixed-pos-parent.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ] fullscreen/full-screen-iframe-zIndex.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac ] fullscreen/full-screen-placeholder.html [
ImageOnlyFailure ]
+crbug.com/334269 [ Mac …
(message too large)

[Mayur Kankanwadi, 2014-11-02 10:54:04]

The CQ bit was unchecked by mayurk.vk@samsung.com

[Mayur Kankanwadi, 2014-11-02 10:54:04]

The CQ bit was checked by mayurk.vk@samsung.com

[commit-bot: I haz the power, 2014-11-02 10:54:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585873002/380001

[commit-bot: I haz the power, 2014-11-02 10:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-02 10:57:14]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 547.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
72a8a77641b8c4adb03bed059a70ba500d477e35..ddf90b0222a3e56575ef01fd62dd536dc61a0f9d
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -547,6 +547,7 @@ public:
         CanvasRenderingContext2DCompositeOperationDarker = 577,
         ScriptElementWithInvalidTypeHasSrc = 578,
         TimelineStart = 579,
+        XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload = 580,
 
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.

[Mayur Kankanwadi, 2014-11-02 11:15:49]

Hi All Reviewers,
This is a call for help in merging this patch
As it turns out, my numerous attempts to commit this patch, with all those
rebases have not been fruitful.
I am stuck, as the files that I have touched are in constant flux.
So in window of working hours, after getting the latest code and rebasing it, I
am still stuck with merging issues.
Any suggestions as to how to commit this?
Should I avoid doing a gclient sync and do a git pull directly on the Blink git
repo?
Any help will be appreciated.
Thanks in advance

[pdr., 2014-11-02 19:18:00]

On 2014/11/02 at 11:15:49, mayurk.vk wrote:
> Hi All Reviewers,
> This is a call for help in merging this patch
> As it turns out, my numerous attempts to commit this patch, with all those
rebases have not been fruitful.
> I am stuck, as the files that I have touched are in constant flux.
> So in window of working hours, after getting the latest code and rebasing it,
I am still stuck with merging issues.
> Any suggestions as to how to commit this?
> Should I avoid doing a gclient sync and do a git pull directly on the Blink
git repo?
> Any help will be appreciated.
> Thanks in advance

The deps entry for Blink should only be a few revisions behind so gclient sync
and "git pull" should checkout almost the same revision. Doing a "git pull" in
webkit/ is definitely an option you can try though.

Can you try syncing, rebasing, uploading, and pressing the CQ button in ~1hr? If
it doesn't work the first time, quickly fix the merge conflict and try again.
These files are constantly changing but you can normally get it to land in 1 or
2 tries.

[Mayur Kankanwadi, 2014-11-03 08:49:03]

The CQ bit was checked by mayurk.vk@samsung.com

[commit-bot: I haz the power, 2014-11-03 08:49:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585873002/400001

[commit-bot: I haz the power, 2014-11-03 10:21:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-03 10:21:21]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/34777)

[Mayur Kankanwadi, 2014-11-03 10:38:56]

The CQ bit was unchecked by mayurk.vk@samsung.com

[Mayur Kankanwadi, 2014-11-03 10:38:56]

The CQ bit was checked by mayurk.vk@samsung.com

[commit-bot: I haz the power, 2014-11-03 10:39:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585873002/420001

[commit-bot: I haz the power, 2014-11-03 11:46:29]

Committed patchset #21 (id:420001) as 184788