Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 585873002: Show a warning when using sync xhr. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added needsrebaseline for win_rel. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 789 matching lines...) Expand 10 before | Expand all | Expand 10 after
800 800
801 case XHRProgressEventTotalSize: 801 case XHRProgressEventTotalSize:
802 return "The XMLHttpRequest progress event property 'totalSize' is deprec ated. Please use 'total' instead."; 802 return "The XMLHttpRequest progress event property 'totalSize' is deprec ated. Please use 'total' instead.";
803 803
804 case ConsoleTimeline: 804 case ConsoleTimeline:
805 return "console.timeline is deprecated. Please use the console.time inst ead."; 805 return "console.timeline is deprecated. Please use the console.time inst ead.";
806 806
807 case ConsoleTimelineEnd: 807 case ConsoleTimelineEnd:
808 return "console.timelineEnd is deprecated. Please use the console.timeEn d instead."; 808 return "console.timelineEnd is deprecated. Please use the console.timeEn d instead.";
809 809
810 case XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload:
811 return "Synchronous XMLHttpRequest on the main thread is deprecated beca use of its detrimental effects to the end user's experience. For more help, chec k http://xhr.spec.whatwg.org/.";
812
810 // Features that aren't deprecated don't have a deprecation message. 813 // Features that aren't deprecated don't have a deprecation message.
811 default: 814 default:
812 return String(); 815 return String();
813 } 816 }
814 } 817 }
815 818
816 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 819 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
817 { 820 {
818 ASSERT(feature >= firstCSSProperty); 821 ASSERT(feature >= firstCSSProperty);
819 ASSERT(feature <= lastCSSProperty); 822 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
848 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 851 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
849 { 852 {
850 // FIXME: We may want to handle stylesheets that have multiple owners 853 // FIXME: We may want to handle stylesheets that have multiple owners
851 // http://crbug.com/242125 854 // http://crbug.com/242125
852 if (sheetContents && sheetContents->hasSingleOwnerNode()) 855 if (sheetContents && sheetContents->hasSingleOwnerNode())
853 return getFrom(sheetContents->singleOwnerDocument()); 856 return getFrom(sheetContents->singleOwnerDocument());
854 return 0; 857 return 0;
855 } 858 }
856 859
857 } // namespace blink 860 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698