Source/core/frame/UseCounter.cpp - Issue 585873002: Show a warning when using sync xhr.

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 585873002: Show a warning when using sync xhr. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed spurious new line deletions. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1	1

2 /*	2 /*

3 * Copyright (C) 2012 Google, Inc. All rights reserved.	3 * Copyright (C) 2012 Google, Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 774 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
785	785

786 case XHRProgressEventTotalSize:	786 case XHRProgressEventTotalSize:

787 return "The XMLHttpRequest progress event property 'totalSize' is deprec ated. Please use 'total' instead.";	787 return "The XMLHttpRequest progress event property 'totalSize' is deprec ated. Please use 'total' instead.";

788	788

789 case ConsoleTimeline:	789 case ConsoleTimeline:

790 return "console.timeline is deprecated. Please use the console.time inst ead.";	790 return "console.timeline is deprecated. Please use the console.time inst ead.";

791	791

792 case ConsoleTimelineEnd:	792 case ConsoleTimelineEnd:

793 return "console.timelineEnd is deprecated. Please use the console.timeEn d instead.";	793 return "console.timelineEnd is deprecated. Please use the console.timeEn d instead.";

794	794

	795 case XMLHttpRequestSynchronous:

	796 return "Synchronous XMLHttpRequest is deprecated. Please use the async v ersion.";
	kouhei (in TOK) 2014/10/14 05:08:49 As Mike said, please use the same text as Firefox As Mike said, please use the same text as Firefox for this warning.
	797

795 // Features that aren't deprecated don't have a deprecation message.	798 // Features that aren't deprecated don't have a deprecation message.

796 default:	799 default:

797 return String();	800 return String();

798 }	801 }

799 }	802 }

800	803

801 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)	804 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)

802 {	805 {

803 ASSERT(feature >= firstCSSProperty);	806 ASSERT(feature >= firstCSSProperty);

804 ASSERT(feature <= lastCSSProperty);	807 ASSERT(feature <= lastCSSProperty);

(...skipping 28 matching lines...) Expand all Loading...
833 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)	836 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)

834 {	837 {

835 // FIXME: We may want to handle stylesheets that have multiple owners	838 // FIXME: We may want to handle stylesheets that have multiple owners

836 // http://crbug.com/242125	839 // http://crbug.com/242125

837 if (sheetContents && sheetContents->hasSingleOwnerNode())	840 if (sheetContents && sheetContents->hasSingleOwnerNode())

838 return getFrom(sheetContents->singleOwnerDocument());	841 return getFrom(sheetContents->singleOwnerDocument());

839 return 0;	842 return 0;

840 }	843 }

841	844

842 } // namespace blink	845 } // namespace blink

OLD	NEW

« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/xml/XMLHttpRequest.cpp » ('j') | Source/core/xml/XMLHttpRequest.cpp » ('J')