Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Side by Side Diff: Source/core/dom/Document.h

Issue 585873002: Show a warning when using sync xhr. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated patch with reset -expected.txt files. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2011 Google Inc. All rights reserved. 9 * Copyright (C) 2011 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1023 matching lines...) Expand 10 before | Expand all | Expand 10 after
1034 virtual void trace(Visitor*) OVERRIDE; 1034 virtual void trace(Visitor*) OVERRIDE;
1035 1035
1036 bool hasSVGFilterElementsRequiringLayerUpdate() const { return m_layerUpdate SVGFilterElements.size(); } 1036 bool hasSVGFilterElementsRequiringLayerUpdate() const { return m_layerUpdate SVGFilterElements.size(); }
1037 void didRecalculateStyleForElement() { ++m_styleRecalcElementCounter; } 1037 void didRecalculateStyleForElement() { ++m_styleRecalcElementCounter; }
1038 1038
1039 AtomicString convertLocalName(const AtomicString&); 1039 AtomicString convertLocalName(const AtomicString&);
1040 1040
1041 virtual v8::Handle<v8::Object> wrap(v8::Handle<v8::Object> creationContext, v8::Isolate*) OVERRIDE; 1041 virtual v8::Handle<v8::Object> wrap(v8::Handle<v8::Object> creationContext, v8::Isolate*) OVERRIDE;
1042 virtual v8::Handle<v8::Object> associateWithWrapper(const WrapperTypeInfo*, v8::Handle<v8::Object> wrapper, v8::Isolate*) OVERRIDE; 1042 virtual v8::Handle<v8::Object> associateWithWrapper(const WrapperTypeInfo*, v8::Handle<v8::Object> wrapper, v8::Isolate*) OVERRIDE;
1043 1043
1044 void setWarnedAboutSyncXHROnce() { m_warnAboutSyncXHROnce = true; }
1045 bool didWarnAboutSyncXHROnce() { return m_warnAboutSyncXHROnce; }
1046
1044 protected: 1047 protected:
1045 Document(const DocumentInit&, DocumentClassFlags = DefaultDocumentClass); 1048 Document(const DocumentInit&, DocumentClassFlags = DefaultDocumentClass);
1046 1049
1047 virtual void didUpdateSecurityOrigin() OVERRIDE FINAL; 1050 virtual void didUpdateSecurityOrigin() OVERRIDE FINAL;
1048 1051
1049 void clearXMLVersion() { m_xmlVersion = String(); } 1052 void clearXMLVersion() { m_xmlVersion = String(); }
1050 1053
1051 #if !ENABLE(OILPAN) 1054 #if !ENABLE(OILPAN)
1052 virtual void dispose() OVERRIDE; 1055 virtual void dispose() OVERRIDE;
1053 #endif 1056 #endif
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
1365 1368
1366 WillBeHeapHashSet<RawPtrWillBeMember<SVGUseElement> > m_useElementsNeedingUp date; 1369 WillBeHeapHashSet<RawPtrWillBeMember<SVGUseElement> > m_useElementsNeedingUp date;
1367 WillBeHeapHashSet<RawPtrWillBeMember<Element> > m_layerUpdateSVGFilterElemen ts; 1370 WillBeHeapHashSet<RawPtrWillBeMember<Element> > m_layerUpdateSVGFilterElemen ts;
1368 1371
1369 bool m_hasViewportUnits; 1372 bool m_hasViewportUnits;
1370 1373
1371 typedef WillBeHeapHashSet<RawPtrWillBeWeakMember<DocumentVisibilityObserver> > DocumentVisibilityObserverSet; 1374 typedef WillBeHeapHashSet<RawPtrWillBeWeakMember<DocumentVisibilityObserver> > DocumentVisibilityObserverSet;
1372 DocumentVisibilityObserverSet m_visibilityObservers; 1375 DocumentVisibilityObserverSet m_visibilityObservers;
1373 1376
1374 int m_styleRecalcElementCounter; 1377 int m_styleRecalcElementCounter;
1378 bool m_warnAboutSyncXHROnce;
kouhei (in TOK) 2014/10/01 11:38:44 m_hasWarnedAboutSyncXHR? I want to avoid adding t
1375 }; 1379 };
1376 1380
1377 inline bool Document::shouldOverrideLegacyDescription(ViewportDescription::Type origin) 1381 inline bool Document::shouldOverrideLegacyDescription(ViewportDescription::Type origin)
1378 { 1382 {
1379 // The different (legacy) meta tags have different priorities based on the t ype 1383 // The different (legacy) meta tags have different priorities based on the t ype
1380 // regardless of which order they appear in the DOM. The priority is given b y the 1384 // regardless of which order they appear in the DOM. The priority is given b y the
1381 // ViewportDescription::Type enum. 1385 // ViewportDescription::Type enum.
1382 return origin >= m_legacyViewportDescription.type; 1386 return origin >= m_legacyViewportDescription.type;
1383 } 1387 }
1384 1388
(...skipping 25 matching lines...) Expand all
1410 Node* eventTargetNodeForDocument(Document*); 1414 Node* eventTargetNodeForDocument(Document*);
1411 1415
1412 } // namespace blink 1416 } // namespace blink
1413 1417
1414 #ifndef NDEBUG 1418 #ifndef NDEBUG
1415 // Outside the WebCore namespace for ease of invocation from gdb. 1419 // Outside the WebCore namespace for ease of invocation from gdb.
1416 void showLiveDocumentInstances(); 1420 void showLiveDocumentInstances();
1417 #endif 1421 #endif
1418 1422
1419 #endif // Document_h 1423 #endif // Document_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698