Compile print_preview, part 1: remove all warnings

Compile print_preview, part 1: remove all warnings

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/print_preview/compiled_resources.gyp && ninja -C out/Default | grep WARNING

Committed: https://crrev.com/f3777e5f4dddcea6036d5e9fca512bacb4abe0e0
Cr-Commit-Position: refs/heads/master@{#296016}

[Vitaly Pavlenko, 2014-09-18 23:23:43]

On 2014/09/17 00:08:26, Vitaly Pavlenko wrote:

ping dbeam@

[Dan Beam, 2014-09-18 23:24:44]

dbeam@chromium.org changed reviewers:
+ dpapad@chromium.org
- dbeam@chromium.org

[Dan Beam, 2014-09-18 23:24:45]

-dbeam, +dpapad

[Vitaly Pavlenko, 2014-09-19 00:25:10]

-dpapad, +thestig

[Vitaly Pavlenko, 2014-09-19 00:25:24]

vitalyp@chromium.org changed reviewers:
+ thestig@chromium.org
- dpapad@chromium.org

[Lei Zhang, 2014-09-19 05:07:07]

+alekseys on this one too

[Vitaly Pavlenko, 2014-09-19 20:51:00]

vitalyp@chromium.org changed reviewers:
+ alekseys@chromium.org

[Lei Zhang, 2014-09-19 21:21:38]

https://codereview.chromium.org/574193002/diff/1/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/compiled_resources.gyp (right):

https://codereview.chromium.org/574193002/diff/1/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/compiled_resources.gyp:1: # Copyright
2014 The Chromium Authors. All rights reserved.
Did you include this file in the CL by accident?

[Lei Zhang, 2014-09-19 21:22:06]

thestig@chromium.org changed reviewers:
+ dbeam@chromium.org

[Lei Zhang, 2014-09-19 21:22:07]

re-adding dbeam for third_party/closure_compiler/processor.py

[Vitaly Pavlenko, 2014-09-19 21:24:55]

https://codereview.chromium.org/574193002/diff/1/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/compiled_resources.gyp (right):

https://codereview.chromium.org/574193002/diff/1/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/compiled_resources.gyp:1: # Copyright
2014 The Chromium Authors. All rights reserved.
On 2014/09/19 21:21:38, Lei Zhang wrote:
> Did you include this file in the CL by accident?

No, I usually include gyp file that runs the closure compile in the first CL
with patches on warnings/errors I'm trying to remove by that CL.

In this CL, you can see that all warnings are gone by running this line:
GYP_GENERATORS=ninja gyp --depth .
chrome/browser/resources/print_preview/compiled_resources.gyp && ninja -C
out/Default | grep WARNING
(need to have Java >=7 on your desktop).

[Vitaly Pavlenko, 2014-09-19 21:25:23]

vitalyp@chromium.org changed reviewers:
- dbeam@chromium.org

[Vitaly Pavlenko, 2014-09-19 21:26:03]

vitalyp@chromium.org changed reviewers:
+ dbeam@chromium.org

[Lei Zhang, 2014-09-19 21:28:51]

On 2014/09/19 21:24:55, Vitaly Pavlenko wrote:
> No, I usually include gyp file that runs the closure compile in the first CL
> with patches on warnings/errors I'm trying to remove by that CL.

Ah, I didn't see the A+ status on the file.

lgtm, but again, give Aleksey a chance to go over the CL.

[Dan Beam, 2014-09-19 21:51:53]

https://codereview.chromium.org/574193002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/processor.py (right):

https://codereview.chromium.org/574193002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/processor.py:76: _INCLUDE_REG =
"<include[^>]+src=['\"]([^>]*)['\"] ?/?>"
remove, https://codereview.chromium.org/588673003

[Vitaly Pavlenko, 2014-09-19 21:59:33]

https://codereview.chromium.org/574193002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/processor.py (right):

https://codereview.chromium.org/574193002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/processor.py:76: _INCLUDE_REG =
"<include[^>]+src=['\"]([^>]*)['\"] ?/?>"
On 2014/09/19 21:51:53, Dan Beam wrote:
> remove, https://codereview.chromium.org/588673003

I added it because there's a lot of such code:
https://code.google.com/p/chromium/codesearch#search/&q=%3Cinclude.%2B/%3E%20...

Do we want to gradually change all of it as we start to compile it?

[Dan Beam, 2014-09-19 22:07:38]

https://codereview.chromium.org/574193002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/processor.py (right):

https://codereview.chromium.org/574193002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/processor.py:76: _INCLUDE_REG =
"<include[^>]+src=['\"]([^>]*)['\"] ?/?>"
On 2014/09/19 21:59:33, Vitaly Pavlenko wrote:
> On 2014/09/19 21:51:53, Dan Beam wrote:
> > remove, https://codereview.chromium.org/588673003
> 
> I added it because there's a lot of such code:
>
https://code.google.com/p/chromium/codesearch#search/&q=%3Cinclude.%2B/%3E%20...
> 
> Do we want to gradually change all of it as we start to compile it?

not gradually, no: https://codereview.chromium.org/586783003/

[Vitaly Pavlenko, 2014-09-19 22:20:17]

https://codereview.chromium.org/574193002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/processor.py (right):

https://codereview.chromium.org/574193002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/processor.py:76: _INCLUDE_REG =
"<include[^>]+src=['\"]([^>]*)['\"] ?/?>"
On 2014/09/19 22:07:37, Dan Beam wrote:
> On 2014/09/19 21:59:33, Vitaly Pavlenko wrote:
> > On 2014/09/19 21:51:53, Dan Beam wrote:
> > > remove, https://codereview.chromium.org/588673003
> > 
> > I added it because there's a lot of such code:
> >
>
https://code.google.com/p/chromium/codesearch#search/&q=%3Cinclude.%2B/%3E%20...
> > 
> > Do we want to gradually change all of it as we start to compile it?
> 
> not gradually, no: https://codereview.chromium.org/586783003/

Ok, reverted my changes.

[Vitaly Pavlenko, 2014-09-22 16:16:54]

On 2014/09/19 22:20:17, Vitaly Pavlenko wrote:
>
https://codereview.chromium.org/574193002/diff/1/third_party/closure_compiler...
> File third_party/closure_compiler/processor.py (right):
> 
>
https://codereview.chromium.org/574193002/diff/1/third_party/closure_compiler...
> third_party/closure_compiler/processor.py:76: _INCLUDE_REG =
> "<include[^>]+src=['\"]([^>]*)['\"] ?/?>"
> On 2014/09/19 22:07:37, Dan Beam wrote:
> > On 2014/09/19 21:59:33, Vitaly Pavlenko wrote:
> > > On 2014/09/19 21:51:53, Dan Beam wrote:
> > > > remove, https://codereview.chromium.org/588673003
> > > 
> > > I added it because there's a lot of such code:
> > >
> >
>
https://code.google.com/p/chromium/codesearch#search/&q=%3Cinclude.%2B/%3E%20...
> > > 
> > > Do we want to gradually change all of it as we start to compile it?
> > 
> > not gradually, no: https://codereview.chromium.org/586783003/
> 
> Ok, reverted my changes.

ping alekseys@

[Aleksey Shlyapnikov, 2014-09-22 17:07:24]

lgtm

[Vitaly Pavlenko, 2014-09-22 17:24:52]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-09-22 17:26:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/574193002/40001

[commit-bot: I haz the power, 2014-09-22 18:26:29]

Committed patchset #3 (id:40001) as 8738812aab254beee11d3d77177a88a42baad933

[commit-bot: I haz the power, 2014-09-22 18:27:02]

Patchset 3 (id:??) landed as
https://crrev.com/f3777e5f4dddcea6036d5e9fca512bacb4abe0e0
Cr-Commit-Position: refs/heads/master@{#296016}