Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 588673003: print_preview: change <include/> to <include>. (Closed)

Created:
6 years, 3 months ago by Dan Beam
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

print_preview: change <include/> to <include>. There's no reason to close the tag. Well-formedness doesn't matter. R=thestig@chromium.org BUG=393873 Committed: https://crrev.com/b9cd4f95c92b4724f268f09462df6330497dc2f1 Cr-Commit-Position: refs/heads/master@{#295808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -93 lines) Patch
M chrome/browser/resources/print_preview/print_preview.html View 2 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 2 chunks +72 lines, -72 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Dan Beam
6 years, 3 months ago (2014-09-19 21:50:56 UTC) #1
Lei Zhang
ok, lgtm BUG= seems wrong.
6 years, 3 months ago (2014-09-19 21:52:49 UTC) #2
Dan Beam
On 2014/09/19 21:52:49, Lei Zhang wrote: > ok, lgtm > > BUG= seems wrong. fixed
6 years, 3 months ago (2014-09-19 21:55:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588673003/1
6 years, 3 months ago (2014-09-19 21:56:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588673003/1
6 years, 3 months ago (2014-09-19 21:56:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as b800a7efeaf30ee792ee874270ba3b8433a8d1c0
6 years, 3 months ago (2014-09-19 23:27:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3fed516d7aceaea00ff91092debd6c341b92d46c
6 years, 3 months ago (2014-09-19 23:27:33 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 23:28:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9cd4f95c92b4724f268f09462df6330497dc2f1
Cr-Commit-Position: refs/heads/master@{#295808}

Powered by Google App Engine
This is Rietveld 408576698