Compile print_preview, part 1: remove all warnings

third_party/closure_compiler/processor.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Process Chrome resources (HTML/CSS/JS) to handle <include> and <if> tags."""
 
 from collections import defaultdict
 import re
 import os
 
@@ skipping 55 matching lines @@
 
   Args:
       source_file: A file to process.
 
   Attributes:
       contents: Expanded contents after inlining <include>s and stripping <if>s.
       included_files: A list of files that were inlined via <include>.
   """
 
   _IF_TAGS_REG = "</?if[^>]*?>"
-  _INCLUDE_REG = "<include[^>]+src=['\"]([^>]*)['\"]>"
+  _INCLUDE_REG = "<include[^>]+src=['\"]([^>]*)['\"] ?/?>"

[Dan Beam, 2014/09/19 21:51:53]

remove, https://codereview.chromium.org/588673003

[Vitaly Pavlenko, 2014/09/19 21:59:33]

I added it because there's a lot of such code:
https://code.google.com/p/chromium/codesearch#search/&q=%3Cinclude.%2B/%3E%20...

Do we want to gradually change all of it as we start to compile it?

[Dan Beam, 2014/09/19 22:07:37]

not gradually, no: https://codereview.chromium.org/586783003/

[Vitaly Pavlenko, 2014/09/19 22:20:17]

Ok, reverted my changes.

 
   def __init__(self, source_file):
     self._included_files = set()
     self._index = 0
     self._lines = self._get_file(source_file)
 
     while self._index < len(self._lines):
       current_line = self._lines[self._index]
       match = re.search(self._INCLUDE_REG, current_line[2])
       if match:
@@ skipping 23 matching lines @@
     Args:
         line_number: A processed file's line number.
     """
     line_number = int(line_number) - 1
     return LineNumber(self._lines[line_number][0], self._lines[line_number][1])
 
   @property
   def included_files(self):
     """A list of files that were inlined via <include>."""
     return self._included_files