chrome/browser/resources/print_preview/compiled_resources.gyp - Issue 574193002: Compile print_preview, part 1: remove all warnings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/print_preview/compiled_resources.gyp

Issue 574193002: Compile print_preview, part 1: remove all warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/common/search_box.js ('k') | chrome/browser/resources/print_preview/data/capabilities_holder.js » ('j') | third_party/closure_compiler/processor.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.
	Lei Zhang 2014/09/19 21:21:38 Did you include this file in the CL by accident? Did you include this file in the CL by accident? Vitaly Pavlenko 2014/09/19 21:24:54 No, I usually include gyp file that runs the closu Show quoted text On 2014/09/19 21:21:38, Lei Zhang wrote: > Did you include this file in the CL by accident? No, I usually include gyp file that runs the closure compile in the first CL with patches on warnings/errors I'm trying to remove by that CL. In this CL, you can see that all warnings are gone by running this line: GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/print_preview/compiled_resources.gyp && ninja -C out/Default \| grep WARNING (need to have Java >=7 on your desktop).
2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 {	4 {

5 'targets': [	5 'targets': [

6 {	6 {

7 'target_name': 'help',	7 'target_name': 'print_preview',

8 'variables': {	8 'variables': {

9 'depends': [	9 'depends': [

10 '../../../../ui/webui/resources/js/assert.js',

11 '../../../../ui/webui/resources/js/cr.js',	10 '../../../../ui/webui/resources/js/cr.js',

12 '../../../../ui/webui/resources/js/cr/event_target.js',	11 '../../../../ui/webui/resources/js/cr/event_target.js',

13 '../../../../ui/webui/resources/js/cr/ui.js',	12 '../../../../ui/webui/resources/js/cr/ui.js',

14 '../../../../ui/webui/resources/js/cr/ui/bubble.js',

15 '../../../../ui/webui/resources/js/cr/ui/focus_manager.js',	13 '../../../../ui/webui/resources/js/cr/ui/focus_manager.js',

16 '../../../../ui/webui/resources/js/cr/ui/focus_outline_manager.js',	14 '../../../../ui/webui/resources/js/cr/ui/focus_outline_manager.js',

17 '../../../../ui/webui/resources/js/cr/ui/overlay.js',

18 '../../../../ui/webui/resources/js/cr/ui/page_manager/page.js',

19 '../../../../ui/webui/resources/js/cr/ui/page_manager/page_manager.js' ,

20 '../../../../ui/webui/resources/js/event_tracker.js',	15 '../../../../ui/webui/resources/js/event_tracker.js',

21 '../../../../ui/webui/resources/js/load_time_data.js',	16 '../../../../ui/webui/resources/js/i18n_template.js',

	17 '../../../../ui/webui/resources/js/local_strings.js',

22 '../../../../ui/webui/resources/js/util.js',	18 '../../../../ui/webui/resources/js/util.js',

23 '../../../../chrome/browser/resources/help/channel_change_page.js',

24 '../../../../chrome/browser/resources/help/help_page.js',

25 ],	19 ],

26 'externs': ['<(CLOSURE_DIR)/externs/chrome_send_externs.js'],	20 'externs': ['<(CLOSURE_DIR)/externs/chrome_send_externs.js'],

27 },	21 },

28 'includes': ['../../../../third_party/closure_compiler/compile_js.gypi'],	22 'includes': ['../../../../third_party/closure_compiler/compile_js.gypi'],

29 }	23 }

30 ],	24 ],

31 }	25 }

OLD	NEW