chrome/browser/resources/print_preview/previewarea/preview_area.js - Issue 574193002: Compile print_preview, part 1: remove all warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/previewarea/preview_area.js

Issue 574193002: Compile print_preview, part 1: remove all warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/previewarea/margin_control_container.js ('k') | chrome/browser/resources/print_preview/search/destination_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/previewarea/preview_area.js

diff --git a/chrome/browser/resources/print_preview/previewarea/preview_area.js b/chrome/browser/resources/print_preview/previewarea/preview_area.js

index ec764e7132a9f104deb40df93422cf8c4d345302..4322349a1608ce986f7d15fa0f820f56b980f8cc 100644

--- a/chrome/browser/resources/print_preview/previewarea/preview_area.js

+++ b/chrome/browser/resources/print_preview/previewarea/preview_area.js

@@ -556,13 +556,6 @@ cr.define('print_preview', function() {

* Called when the open-system-dialog button is clicked. Disables the

* button, shows the throbber, and dispatches the OPEN_SYSTEM_DIALOG_CLICK

* event.

- * @param {number} pageX the x-coordinate of the page relative to the

- * screen.

- * @param {number} pageY the y-coordinate of the page relative to the

- * screen.

- * @param {number} pageWidth the width of the page on the screen.

- * @param {number} viewportWidth the width of the viewport.

- * @param {number} viewportHeight the height of the viewport.

* @private

onOpenSystemDialogButtonClick_: function() {

@@ -594,7 +587,7 @@ cr.define('print_preview', function() {

/**

* Called when the preview generator begins loading the preview.

- * @param {Event} Contains the URL to initialize the plugin to.

+ * @param {Event} event Contains the URL to initialize the plugin to.

* @private

onPreviewStart_: function(event) {