Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 572853002: Realigning the WeakPtrFactory initialization order in chrome/ui folder (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, vsevik, sadrul, oshima+watch_chromium.org, benquan, tfarina, stevenjb+watch_chromium.org, devtools-reviews_chromium.org, ben+ash_chromium.org, yurys, paulirish+reviews_chromium.org, Dane Wallinga, dyu1, kalyank, estade+watch_chromium.org, aandrey+blink_chromium.org, Ilya Sherman, pfeldman, rouslan+autofillwatch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Realigning the WeakPtrFactory initialization order in chrome/ui folder Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/1f994399ef31e88d09141a071e3ef08c3adfdead Cr-Commit-Position: refs/heads/master@{#295233}

Patch Set 1 #

Patch Set 2 : Fixed mac error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -58 lines) Patch
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/search/people/people_result.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac.h View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac.mm View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
MRV
PTAL
6 years, 3 months ago (2014-09-16 06:32:17 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-16 22:02:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572853002/1
6 years, 3 months ago (2014-09-17 01:57:18 UTC) #5
MRV
On 2014/09/16 22:02:44, sky wrote: > LGTM Thanks mr.sky for lgtm
6 years, 3 months ago (2014-09-17 01:57:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/56887)
6 years, 3 months ago (2014-09-17 02:07:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572853002/20001
6 years, 3 months ago (2014-09-17 02:51:16 UTC) #10
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-17 04:52:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572853002/20001
6 years, 3 months ago (2014-09-17 05:03:50 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 40141417852c5f023ade5a49c5dd6f203cfd3e90
6 years, 3 months ago (2014-09-17 05:30:13 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 05:30:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f994399ef31e88d09141a071e3ef08c3adfdead
Cr-Commit-Position: refs/heads/master@{#295233}

Powered by Google App Engine
This is Rietveld 408576698