|
Realigning the WeakPtrFactory initialization order in chrome/ui folder
Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.
BUG= 303818
Committed: https://crrev.com/1f994399ef31e88d09141a071e3ef08c3adfdead
Cr-Commit-Position: refs/heads/master@{#295233}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+63 lines, -58 lines) |
Patch |
 |
M |
chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/app_list/app_list_service_impl.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/app_list/app_list_service_impl.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/app_list/search/people/people_result.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/screenshot_taker.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/screenshot_taker.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/system_tray_delegate_chromeos.h
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/browser.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/browser.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/status_bubble_mac.h
|
View
|
|
2 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/status_bubble_mac.mm
|
View
|
1
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/devtools_ui.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/print_preview/print_preview_handler.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/signin/inline_login_handler_impl.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 16 (6 generated)
|