chrome/browser/ui/cocoa/status_bubble_mac.mm - Issue 572853002: Realigning the WeakPtrFactory initialization order in chrome/ui folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/status_bubble_mac.mm

Issue 572853002: Realigning the WeakPtrFactory initialization order in chrome/ui folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed mac error Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/status_bubble_mac.h ('k') | chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/status_bubble_mac.mm

diff --git a/chrome/browser/ui/cocoa/status_bubble_mac.mm b/chrome/browser/ui/cocoa/status_bubble_mac.mm

index ddf00ace198ee221a7d3f76e1661053113d40bcc..6fcbc2f8c6ab2164b7206ab36ffe48f965b559e6 100644

--- a/chrome/browser/ui/cocoa/status_bubble_mac.mm

+++ b/chrome/browser/ui/cocoa/status_bubble_mac.mm

@@ -143,17 +143,17 @@ const CGFloat kExpansionDurationSeconds = 0.125;

@end

StatusBubbleMac::StatusBubbleMac(NSWindow* parent, id delegate)

- : timer_factory_(this),

- expand_timer_factory_(this),

- completion_handler_factory_(this),

- parent_(parent),

+ : parent_(parent),

delegate_(delegate),

window_(nil),

status_text_(nil),

url_text_(nil),

state_(kBubbleHidden),

immediate_(false),

- is_expanded_(false) {

+ is_expanded_(false),

+ timer_factory_(this),

+ expand_timer_factory_(this),

+ completion_handler_factory_(this) {

Create();

Attach();

}

« no previous file with comments | « chrome/browser/ui/cocoa/status_bubble_mac.h ('k') | chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h » ('j') | no next file with comments »