chrome/browser/ui/webui/devtools_ui.h - Issue 572853002: Realigning the WeakPtrFactory initialization order in chrome/ui folder

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/devtools_ui.h

Issue 572853002: Realigning the WeakPtrFactory initialization order in chrome/ui folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed mac error Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc ('k') | chrome/browser/ui/webui/print_preview/print_preview_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_WEBUI_DEVTOOLS_UI_H_	5 #ifndef CHROME_BROWSER_UI_WEBUI_DEVTOOLS_UI_H_

6 #define CHROME_BROWSER_UI_WEBUI_DEVTOOLS_UI_H_	6 #define CHROME_BROWSER_UI_WEBUI_DEVTOOLS_UI_H_

7	7

8 #include "base/compiler_specific.h"	8 #include "base/compiler_specific.h"

9 #include "base/memory/weak_ptr.h"	9 #include "base/memory/weak_ptr.h"

10 #include "chrome/browser/devtools/device/devtools_android_bridge.h"	10 #include "chrome/browser/devtools/device/devtools_android_bridge.h"

(...skipping 13 matching lines...) Expand all Loading...
24	24

25 // content::WebContentsObserver overrides.	25 // content::WebContentsObserver overrides.

26 virtual void NavigationEntryCommitted(	26 virtual void NavigationEntryCommitted(

27 const content::LoadCommittedDetails& load_details) OVERRIDE;	27 const content::LoadCommittedDetails& load_details) OVERRIDE;

28	28

29 private:	29 private:

30 void RemotePageOpened(const GURL& virtual_url,	30 void RemotePageOpened(const GURL& virtual_url,

31 DevToolsAndroidBridge::RemotePage* page);	31 DevToolsAndroidBridge::RemotePage* page);

32	32

33 DevToolsUIBindings bindings_;	33 DevToolsUIBindings bindings_;

34 base::WeakPtrFactory<DevToolsUI> weak_factory_;

35 GURL remote_frontend_loading_url_;	34 GURL remote_frontend_loading_url_;

36 GURL remote_page_opening_url_;	35 GURL remote_page_opening_url_;

	36 base::WeakPtrFactory<DevToolsUI> weak_factory_;

37 DISALLOW_COPY_AND_ASSIGN(DevToolsUI);	37 DISALLOW_COPY_AND_ASSIGN(DevToolsUI);

38 };	38 };

39	39

40 #endif // CHROME_BROWSER_UI_WEBUI_DEVTOOLS_UI_H_	40 #endif // CHROME_BROWSER_UI_WEBUI_DEVTOOLS_UI_H_

OLD	NEW