Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6426)

Unified Diff: chrome/browser/ui/app_list/app_list_service_impl.cc

Issue 572853002: Realigning the WeakPtrFactory initialization order in chrome/ui folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed mac error Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_service_impl.cc
diff --git a/chrome/browser/ui/app_list/app_list_service_impl.cc b/chrome/browser/ui/app_list/app_list_service_impl.cc
index 0689959f7e548f3fcdb8744befeaf024c386ced4..458850b294c2437e7fc8ffdaf5a6b624fa305f3d 100644
--- a/chrome/browser/ui/app_list/app_list_service_impl.cc
+++ b/chrome/browser/ui/app_list/app_list_service_impl.cc
@@ -229,10 +229,10 @@ void AppListServiceImpl::SendAppListStats() {
AppListServiceImpl::AppListServiceImpl()
: profile_store_(
new ProfileStoreImpl(g_browser_process->profile_manager())),
- weak_factory_(this),
command_line_(*CommandLine::ForCurrentProcess()),
local_state_(g_browser_process->local_state()),
- profile_loader_(new ProfileLoader(profile_store_.get())) {
+ profile_loader_(new ProfileLoader(profile_store_.get())),
+ weak_factory_(this) {
profile_store_->AddProfileObserver(this);
}
@@ -240,10 +240,10 @@ AppListServiceImpl::AppListServiceImpl(const CommandLine& command_line,
PrefService* local_state,
scoped_ptr<ProfileStore> profile_store)
: profile_store_(profile_store.Pass()),
- weak_factory_(this),
command_line_(command_line),
local_state_(local_state),
- profile_loader_(new ProfileLoader(profile_store_.get())) {
+ profile_loader_(new ProfileLoader(profile_store_.get())),
+ weak_factory_(this) {
profile_store_->AddProfileObserver(this);
}
« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_impl.h ('k') | chrome/browser/ui/app_list/search/people/people_result.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698