chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc - Issue 572853002: Realigning the WeakPtrFactory initialization order in chrome/ui folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

Issue 572853002: Realigning the WeakPtrFactory initialization order in chrome/ui folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed mac error Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h ('k') | chrome/browser/ui/app_list/app_list_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

diff --git a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

index c347186c8984bd360cf749b76b14f52ecba8b552..16c3902033be93a1f1df372b73109a344eecfffe 100644

--- a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

+++ b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

@@ -514,8 +514,8 @@ AutofillDialogControllerAndroid::AutofillDialogControllerAndroid(

source_url_(source_url),

callback_(callback),

cares_about_shipping_(true),

- weak_ptr_factory_(this),

- was_ui_latency_logged_(false) {

+ was_ui_latency_logged_(false),

+ weak_ptr_factory_(this) {

DCHECK(!callback_.is_null());

}