|
Move geometry generation out of RenderSVGResource*::postApplyResource
The code-paths that will operate on RenderSVGResources that are
paint-servers are quite easily distinguishable from those where other
resources are involved - and because all paint-servers have the same kind
of geometry generation it's trivially hoistable into the relevant
callsites.
This allows the argument list of postApplyResource to be shortened
(removing |path|, |shape| and |resourceMode| since they are now unused).
Since all callers of the hoisted function (fillOrStrokePrimitive) passes
either a |shape| or a |path| - but never both, we can split this method into
its two logical parts.
Doing this however reveal that the |shape| variant can be trivially folded
into it's callers since they will always end up calling the same method.
This means that fillOrStrokePrimitive is replaced with/transformed into
fillOrStrokePath.
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182004
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+45 lines, -57 lines) |
Patch |
|
M |
Source/core/rendering/svg/RenderSVGResource.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourceClipper.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourceClipper.cpp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourceFilter.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourceFilter.cpp
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourceGradient.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourceGradient.cpp
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourceMasker.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourceMasker.cpp
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourcePattern.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourcePattern.cpp
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourceSolidColor.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGResourceSolidColor.cpp
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/RenderSVGShape.cpp
|
View
|
|
2 chunks |
+12 lines, -6 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/SVGInlineTextBox.cpp
|
View
|
|
5 chunks |
+9 lines, -7 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/SVGRenderSupport.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/SVGRenderSupport.cpp
|
View
|
1
|
1 chunk |
+5 lines, -13 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/SVGRenderingContext.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/svg/SVGTextRunRenderingContext.cpp
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
Total messages: 7 (3 generated)
|