Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

Issue 571923002: Move geometry generation out of RenderSVGResource*::postApplyResource (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Drop curly braces. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/svg/SVGRenderingContext.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 3 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 #include "config.h" 21 #include "config.h"
22 22
23 #if ENABLE(SVG_FONTS) 23 #if ENABLE(SVG_FONTS)
24 #include "core/rendering/svg/SVGTextRunRenderingContext.h" 24 #include "core/rendering/svg/SVGTextRunRenderingContext.h"
25 25
26 #include "core/rendering/RenderObject.h" 26 #include "core/rendering/RenderObject.h"
27 #include "core/rendering/svg/RenderSVGInlineText.h" 27 #include "core/rendering/svg/RenderSVGInlineText.h"
28 #include "core/rendering/svg/RenderSVGResourceSolidColor.h" 28 #include "core/rendering/svg/RenderSVGResourceSolidColor.h"
29 #include "core/rendering/svg/SVGRenderSupport.h"
29 #include "core/svg/SVGFontData.h" 30 #include "core/svg/SVGFontData.h"
30 #include "core/svg/SVGFontElement.h" 31 #include "core/svg/SVGFontElement.h"
31 #include "core/svg/SVGFontFaceElement.h" 32 #include "core/svg/SVGFontFaceElement.h"
32 #include "core/svg/SVGGlyphElement.h" 33 #include "core/svg/SVGGlyphElement.h"
33 #include "platform/fonts/GlyphBuffer.h" 34 #include "platform/fonts/GlyphBuffer.h"
34 #include "platform/fonts/WidthIterator.h" 35 #include "platform/fonts/WidthIterator.h"
35 #include "platform/graphics/GraphicsContext.h" 36 #include "platform/graphics/GraphicsContext.h"
36 37
37 namespace blink { 38 namespace blink {
38 39
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 glyphPathTransform.translate(currentPoint.x() + glyphOrigin.x(), current Point.y() + glyphOrigin.y()); 158 glyphPathTransform.translate(currentPoint.x() + glyphOrigin.x(), current Point.y() + glyphOrigin.y());
158 glyphPathTransform.scale(scale, -scale); 159 glyphPathTransform.scale(scale, -scale);
159 160
160 Path glyphPath = svgGlyph.pathData; 161 Path glyphPath = svgGlyph.pathData;
161 glyphPath.transform(glyphPathTransform); 162 glyphPath.transform(glyphPathTransform);
162 163
163 if (activePaintingResource->applyResource(parentRenderObject, parentRend erObjectStyle, context, resourceMode)) { 164 if (activePaintingResource->applyResource(parentRenderObject, parentRend erObjectStyle, context, resourceMode)) {
164 float strokeThickness = context->strokeThickness(); 165 float strokeThickness = context->strokeThickness();
165 if (renderObject && renderObject->isSVGInlineText()) 166 if (renderObject && renderObject->isSVGInlineText())
166 context->setStrokeThickness(strokeThickness * toRenderSVGInlineT ext(renderObject)->scalingFactor()); 167 context->setStrokeThickness(strokeThickness * toRenderSVGInlineT ext(renderObject)->scalingFactor());
167 activePaintingResource->postApplyResource(parentRenderObject, contex t, resourceMode, &glyphPath, 0); 168 SVGRenderSupport::fillOrStrokePath(context, resourceMode, glyphPath) ;
169 activePaintingResource->postApplyResource(parentRenderObject, contex t);
168 context->setStrokeThickness(strokeThickness); 170 context->setStrokeThickness(strokeThickness);
169 } 171 }
170 172
171 if (isVerticalText) 173 if (isVerticalText)
172 currentPoint.move(0, advance); 174 currentPoint.move(0, advance);
173 else 175 else
174 currentPoint.move(advance, 0); 176 currentPoint.move(advance, 0);
175 } 177 }
176 } 178 }
177 179
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 // Restore original state of the SVG Font glyph table and the current font f allback list, 247 // Restore original state of the SVG Font glyph table and the current font f allback list,
246 // to assure the next lookup of the same glyph won't immediately return the fallback glyph. 248 // to assure the next lookup of the same glyph won't immediately return the fallback glyph.
247 page->setGlyphDataForCharacter(character, glyphData.glyph, originalFontData) ; 249 page->setGlyphDataForCharacter(character, glyphData.glyph, originalFontData) ;
248 ASSERT(fallbackGlyphData.fontData); 250 ASSERT(fallbackGlyphData.fontData);
249 return fallbackGlyphData; 251 return fallbackGlyphData;
250 } 252 }
251 253
252 } 254 }
253 255
254 #endif 256 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/SVGRenderingContext.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698