Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: Source/core/rendering/svg/RenderSVGResourceClipper.h

Issue 571923002: Move geometry generation out of RenderSVGResource*::postApplyResource (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Drop curly braces. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 26 matching lines...) Expand all
37 37
38 explicit RenderSVGResourceClipper(SVGClipPathElement*); 38 explicit RenderSVGResourceClipper(SVGClipPathElement*);
39 virtual ~RenderSVGResourceClipper(); 39 virtual ~RenderSVGResourceClipper();
40 40
41 virtual const char* renderName() const OVERRIDE { return "RenderSVGResourceC lipper"; } 41 virtual const char* renderName() const OVERRIDE { return "RenderSVGResourceC lipper"; }
42 42
43 virtual void removeAllClientsFromCache(bool markForInvalidation = true) OVER RIDE; 43 virtual void removeAllClientsFromCache(bool markForInvalidation = true) OVER RIDE;
44 virtual void removeClientFromCache(RenderObject*, bool markForInvalidation = true) OVERRIDE; 44 virtual void removeClientFromCache(RenderObject*, bool markForInvalidation = true) OVERRIDE;
45 45
46 virtual bool applyResource(RenderObject*, RenderStyle*, GraphicsContext*&, u nsigned short resourceMode) OVERRIDE; 46 virtual bool applyResource(RenderObject*, RenderStyle*, GraphicsContext*&, u nsigned short resourceMode) OVERRIDE;
47 virtual void postApplyResource(RenderObject*, GraphicsContext*&, unsigned sh ort, const Path*, const RenderSVGShape*) OVERRIDE; 47 virtual void postApplyResource(RenderObject*, GraphicsContext*&) OVERRIDE;
48 48
49 // FIXME: Filters are also stateful resources that could benefit from having their state managed 49 // FIXME: Filters are also stateful resources that could benefit from having their state managed
50 // on the caller stack instead of the current hashmap. We should look at refactoring these 50 // on the caller stack instead of the current hashmap. We should look at refactoring these
51 // into a general interface that can be shared. 51 // into a general interface that can be shared.
52 bool applyStatefulResource(RenderObject*, GraphicsContext*&, ClipperState&); 52 bool applyStatefulResource(RenderObject*, GraphicsContext*&, ClipperState&);
53 void postApplyStatefulResource(RenderObject*, GraphicsContext*&, ClipperStat e&); 53 void postApplyStatefulResource(RenderObject*, GraphicsContext*&, ClipperStat e&);
54 54
55 // clipPath can be clipped too, but don't have a boundingBox or paintInvalid ationRect. So we can't call 55 // clipPath can be clipped too, but don't have a boundingBox or paintInvalid ationRect. So we can't call
56 // applyResource directly and use the rects from the object, since they are empty for RenderSVGResources 56 // applyResource directly and use the rects from the object, since they are empty for RenderSVGResources
57 // FIXME: We made applyClippingToContext public because we cannot call apply Resource on HTML elements (it asserts on RenderObject::objectBoundingBox) 57 // FIXME: We made applyClippingToContext public because we cannot call apply Resource on HTML elements (it asserts on RenderObject::objectBoundingBox)
(...skipping 19 matching lines...) Expand all
77 77
78 // Reference cycle detection. 78 // Reference cycle detection.
79 bool m_inClipExpansion; 79 bool m_inClipExpansion;
80 }; 80 };
81 81
82 DEFINE_RENDER_SVG_RESOURCE_TYPE_CASTS(RenderSVGResourceClipper, ClipperResourceT ype); 82 DEFINE_RENDER_SVG_RESOURCE_TYPE_CASTS(RenderSVGResourceClipper, ClipperResourceT ype);
83 83
84 } 84 }
85 85
86 #endif 86 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGResource.h ('k') | Source/core/rendering/svg/RenderSVGResourceClipper.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698