Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 570763003: Remove unneeded bool from RenderView::selectionBounds (Closed)

Created:
6 years, 3 months ago by Julien - ping for review
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove unneeded bool from RenderView::selectionBounds The boolean was added in r21387 and the added test (fast/overflow/scroll-nested-positioned-layer-in-overflow.html) is still passing. AFAICT the only adverse potential for this removal is to invalidate more (as we don't apply the ancestors' clips) The only meaningful test change is fast/repaint/text-selection-rect-in-overflow-2.html which had bad invalidations anyway (halfway through the selection) so I don't think it's meaningful. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182197

Patch Set 1 #

Patch Set 2 : Rebaselined change. #

Patch Set 3 : Rebaselined (again) #

Patch Set 4 : Rebaselined (again and again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -49 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/selection-rl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/text-selection-rect-in-overflow-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/text-selection-rect-in-overflow-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBR.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderReplaced.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderSelectionInfo.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderText.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderView.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (10 generated)
Julien - ping for review
6 years, 3 months ago (2014-09-15 17:56:46 UTC) #2
leviw_travelin_and_unemployed
lgtm!
6 years, 3 months ago (2014-09-15 19:31:46 UTC) #3
yosin_UTC9
LGTM (^_^)b Thanks for cleanup! |bool| parameter makes our life harder...
6 years, 3 months ago (2014-09-16 03:36:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570763003/1
6 years, 3 months ago (2014-09-16 17:13:42 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/RenderSelectionInfo.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-09-16 17:13:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570763003/20001
6 years, 3 months ago (2014-09-16 22:12:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/15324)
6 years, 3 months ago (2014-09-16 22:23:36 UTC) #12
Julien - ping for review
Eric, Elliott: Your Source/web/ approval is required for a 1-line change in this directory.
6 years, 3 months ago (2014-09-17 01:00:54 UTC) #13
esprehn
lgtm
6 years, 3 months ago (2014-09-17 01:15:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570763003/20001
6 years, 3 months ago (2014-09-17 17:38:49 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/27506)
6 years, 3 months ago (2014-09-17 17:47:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570763003/40001
6 years, 3 months ago (2014-09-17 19:31:52 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/10814) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57323)
6 years, 3 months ago (2014-09-17 19:36:26 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570763003/60001
6 years, 3 months ago (2014-09-17 21:51:18 UTC) #24
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 22:57:55 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 182197

Powered by Google App Engine
This is Rietveld 408576698