Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: Source/core/rendering/RenderSelectionInfo.h

Issue 570763003: Remove unneeded bool from RenderView::selectionBounds (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined (again and again) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderReplaced.cpp ('k') | Source/core/rendering/RenderText.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 59
60 protected: 60 protected:
61 RawPtrWillBeMember<RenderObject> m_object; 61 RawPtrWillBeMember<RenderObject> m_object;
62 RawPtrWillBeMember<const RenderLayerModelObject> m_paintInvalidationContaine r; 62 RawPtrWillBeMember<const RenderLayerModelObject> m_paintInvalidationContaine r;
63 RenderObject::SelectionState m_state; 63 RenderObject::SelectionState m_state;
64 }; 64 };
65 65
66 // This struct is used when the selection changes to cache the old and new state of the selection for each RenderObject. 66 // This struct is used when the selection changes to cache the old and new state of the selection for each RenderObject.
67 class RenderSelectionInfo FINAL : public RenderSelectionInfoBase { 67 class RenderSelectionInfo FINAL : public RenderSelectionInfoBase {
68 public: 68 public:
69 RenderSelectionInfo(RenderObject* o, bool clipToVisibleContent) 69 RenderSelectionInfo(RenderObject* o)
70 : RenderSelectionInfoBase(o) 70 : RenderSelectionInfoBase(o)
71 { 71 {
72 if (m_paintInvalidationContainer && o->canUpdateSelectionOnRootLineBoxes ()) { 72 if (m_paintInvalidationContainer && o->canUpdateSelectionOnRootLineBoxes ()) {
73 m_rect = o->selectionRectForPaintInvalidation(m_paintInvalidationCon tainer, clipToVisibleContent); 73 m_rect = o->selectionRectForPaintInvalidation(m_paintInvalidationCon tainer);
74 // FIXME: groupedMapping() leaks the squashing abstraction. See Rend erBlockSelectionInfo for more details. 74 // FIXME: groupedMapping() leaks the squashing abstraction. See Rend erBlockSelectionInfo for more details.
75 if (m_paintInvalidationContainer->layer()->groupedMapping()) 75 if (m_paintInvalidationContainer->layer()->groupedMapping())
76 RenderLayer::mapRectToPaintBackingCoordinates(m_paintInvalidatio nContainer, m_rect); 76 RenderLayer::mapRectToPaintBackingCoordinates(m_paintInvalidatio nContainer, m_rect);
77 } else { 77 } else {
78 m_rect = LayoutRect(); 78 m_rect = LayoutRect();
79 } 79 }
80 } 80 }
81 81
82 void invalidatePaint() 82 void invalidatePaint()
83 { 83 {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 GapRects rects() const { return m_rects; } 117 GapRects rects() const { return m_rects; }
118 118
119 private: 119 private:
120 GapRects m_rects; // relative to paint invalidation container 120 GapRects m_rects; // relative to paint invalidation container
121 }; 121 };
122 122
123 } // namespace blink 123 } // namespace blink
124 124
125 125
126 #endif // RenderSelectionInfo_h 126 #endif // RenderSelectionInfo_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderReplaced.cpp ('k') | Source/core/rendering/RenderText.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698