Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: Source/core/rendering/RenderBlock.h

Issue 570763003: Remove unneeded bool from RenderView::selectionBounds (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined (again and again) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderBR.h ('k') | Source/core/rendering/RenderListMarker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 // Obtains the nearest enclosing block (including this block) that contribut es a first-line style to our inline 385 // Obtains the nearest enclosing block (including this block) that contribut es a first-line style to our inline
386 // children. 386 // children.
387 virtual RenderBlock* firstLineBlock() const OVERRIDE; 387 virtual RenderBlock* firstLineBlock() const OVERRIDE;
388 388
389 virtual LayoutRect rectWithOutlineForPaintInvalidation(const RenderLayerMode lObject* paintInvalidationContainer, LayoutUnit outlineWidth, const PaintInvalid ationState* = 0) const OVERRIDE FINAL; 389 virtual LayoutRect rectWithOutlineForPaintInvalidation(const RenderLayerMode lObject* paintInvalidationContainer, LayoutUnit outlineWidth, const PaintInvalid ationState* = 0) const OVERRIDE FINAL;
390 390
391 virtual RenderObject* hoverAncestor() const OVERRIDE FINAL; 391 virtual RenderObject* hoverAncestor() const OVERRIDE FINAL;
392 virtual void updateDragState(bool dragOn) OVERRIDE FINAL; 392 virtual void updateDragState(bool dragOn) OVERRIDE FINAL;
393 virtual void childBecameNonInline(RenderObject* child) OVERRIDE FINAL; 393 virtual void childBecameNonInline(RenderObject* child) OVERRIDE FINAL;
394 394
395 virtual LayoutRect selectionRectForPaintInvalidation(const RenderLayerModelO bject* paintInvalidationContainer, bool /*clipToVisibleContent*/) const OVERRIDE FINAL 395 virtual LayoutRect selectionRectForPaintInvalidation(const RenderLayerModelO bject* paintInvalidationContainer) const OVERRIDE FINAL
396 { 396 {
397 return selectionGapRectsForPaintInvalidation(paintInvalidationContainer) ; 397 return selectionGapRectsForPaintInvalidation(paintInvalidationContainer) ;
398 } 398 }
399 bool isSelectionRoot() const; 399 bool isSelectionRoot() const;
400 GapRects blockSelectionGaps(const RenderBlock* rootBlock, const LayoutPoint& rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock, 400 GapRects blockSelectionGaps(const RenderBlock* rootBlock, const LayoutPoint& rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock,
401 LayoutUnit& lastLogicalTop, LayoutUnit& lastLogi calLeft, LayoutUnit& lastLogicalRight, const PaintInfo*) const; 401 LayoutUnit& lastLogicalTop, LayoutUnit& lastLogi calLeft, LayoutUnit& lastLogicalRight, const PaintInfo*) const;
402 LayoutRect blockSelectionGap(const RenderBlock* rootBlock, const LayoutPoint & rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock, 402 LayoutRect blockSelectionGap(const RenderBlock* rootBlock, const LayoutPoint & rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock,
403 LayoutUnit lastLogicalTop, LayoutUnit lastLogic alLeft, LayoutUnit lastLogicalRight, LayoutUnit logicalBottom, const PaintInfo*) const; 403 LayoutUnit lastLogicalTop, LayoutUnit lastLogic alLeft, LayoutUnit lastLogicalRight, LayoutUnit logicalBottom, const PaintInfo*) const;
404 404
405 // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved to Rend erBlockFlow 405 // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved to Rend erBlockFlow
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
498 // FIXME: This is temporary as we move code that accesses block flow 498 // FIXME: This is temporary as we move code that accesses block flow
499 // member variables out of RenderBlock and into RenderBlockFlow. 499 // member variables out of RenderBlock and into RenderBlockFlow.
500 friend class RenderBlockFlow; 500 friend class RenderBlockFlow;
501 }; 501 };
502 502
503 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock()); 503 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock());
504 504
505 } // namespace blink 505 } // namespace blink
506 506
507 #endif // RenderBlock_h 507 #endif // RenderBlock_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBR.h ('k') | Source/core/rendering/RenderListMarker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698