Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Side by Side Diff: Source/core/rendering/RenderView.h

Issue 570763003: Remove unneeded bool from RenderView::selectionBounds (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined (again and again) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderText.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 93
94 virtual void paint(PaintInfo&, const LayoutPoint&) OVERRIDE; 94 virtual void paint(PaintInfo&, const LayoutPoint&) OVERRIDE;
95 virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&) OV ERRIDE; 95 virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&) OV ERRIDE;
96 96
97 enum SelectionPaintInvalidationMode { PaintInvalidationNewXOROld, PaintInval idationNewMinusOld, PaintInvalidationNothing }; 97 enum SelectionPaintInvalidationMode { PaintInvalidationNewXOROld, PaintInval idationNewMinusOld, PaintInvalidationNothing };
98 void setSelection(RenderObject* start, int startPos, RenderObject*, int endP os, SelectionPaintInvalidationMode = PaintInvalidationNewXOROld); 98 void setSelection(RenderObject* start, int startPos, RenderObject*, int endP os, SelectionPaintInvalidationMode = PaintInvalidationNewXOROld);
99 void getSelection(RenderObject*& startRenderer, int& startOffset, RenderObje ct*& endRenderer, int& endOffset) const; 99 void getSelection(RenderObject*& startRenderer, int& startOffset, RenderObje ct*& endRenderer, int& endOffset) const;
100 void clearSelection(); 100 void clearSelection();
101 RenderObject* selectionStart() const { return m_selectionStart; } 101 RenderObject* selectionStart() const { return m_selectionStart; }
102 RenderObject* selectionEnd() const { return m_selectionEnd; } 102 RenderObject* selectionEnd() const { return m_selectionEnd; }
103 IntRect selectionBounds(bool clipToVisibleContent = true) const; 103 IntRect selectionBounds() const;
104 void selectionStartEnd(int& startPos, int& endPos) const; 104 void selectionStartEnd(int& startPos, int& endPos) const;
105 void invalidatePaintForSelection() const; 105 void invalidatePaintForSelection() const;
106 106
107 virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedO ffset) const OVERRIDE; 107 virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedO ffset) const OVERRIDE;
108 virtual void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const OVERRID E; 108 virtual void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const OVERRID E;
109 109
110 virtual LayoutRect viewRect() const OVERRIDE; 110 virtual LayoutRect viewRect() const OVERRIDE;
111 111
112 bool shouldDoFullPaintInvalidationForNextLayout() const; 112 bool shouldDoFullPaintInvalidationForNextLayout() const;
113 bool doingFullPaintInvalidation() const { return m_frameView->needsFullPaint Invalidation(); } 113 bool doingFullPaintInvalidation() const { return m_frameView->needsFullPaint Invalidation(); }
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 m_paintInvalidationState->m_cachedOffsetsEnabled = true; 231 m_paintInvalidationState->m_cachedOffsetsEnabled = true;
232 } 232 }
233 private: 233 private:
234 const PaintInvalidationState* m_paintInvalidationState; 234 const PaintInvalidationState* m_paintInvalidationState;
235 bool m_didDisable; 235 bool m_didDisable;
236 }; 236 };
237 237
238 } // namespace blink 238 } // namespace blink
239 239
240 #endif // RenderView_h 240 #endif // RenderView_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderText.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698