Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 564453002: Blink GC plugin: Check polymorphic requirements on all GC-derived classes. (Closed)

Created:
6 years, 3 months ago by zerny-chromium
Modified:
6 years, 3 months ago
CC:
chromium-reviews, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Blink GC plugin: Check polymorphic requirements on all GC-derived classes. Prior to this change we only checked the polymorphic requirements on classes that declared a trace method. Also, this fixes a typo in condition (2) where we checked on the derived class instead of the left-most class. R=ager@chromium.org BUG= Committed: https://crrev.com/f691be3b1bbbfb491e9afd283fe100acda894147 Cr-Commit-Position: refs/heads/master@{#294360}

Patch Set 1 #

Patch Set 2 : rebase and fix test error from previous CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 5 chunks +12 lines, -7 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt View 1 chunk +4 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
zerny-chromium
6 years, 3 months ago (2014-09-10 13:15:07 UTC) #1
zerny-chromium
Fixes unreported error issue as found in: https://codereview.chromium.org/562573002/ Compiling with this fix does not find ...
6 years, 3 months ago (2014-09-10 13:22:45 UTC) #2
Mads Ager (chromium)
LGTM
6 years, 3 months ago (2014-09-10 14:39:45 UTC) #3
wibling-chromium
lgtm
6 years, 3 months ago (2014-09-10 15:58:16 UTC) #5
haraken
LGTM
6 years, 3 months ago (2014-09-10 15:59:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564453002/20001
6 years, 3 months ago (2014-09-11 08:01:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 76819f6eb89d7663bf9e91e16dfcf55430b8802f
6 years, 3 months ago (2014-09-11 09:01:43 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 09:03:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f691be3b1bbbfb491e9afd283fe100acda894147
Cr-Commit-Position: refs/heads/master@{#294360}

Powered by Google App Engine
This is Rietveld 408576698